Re: RFR :8023563: Bottleneck in java.util.TimeZone.getDefaultInAppContext

2013-09-03 Thread Alan Bateman
On 02/09/2013 22:58, Seán Coffey wrote: Some minor modification (and further simplifying of conditions) : http://cr.openjdk.java.net/~coffeys/webrev.8023563.3/webrev/ This looks much better. -Alan.

Re: RFR :8023563: Bottleneck in java.util.TimeZone.getDefaultInAppContext

2013-09-03 Thread Chris Hegarty
On 2 Sep 2013, at 22:58, Seán Coffey wrote: > Some minor modification (and further simplifying of conditions) : > > http://cr.openjdk.java.net/~coffeys/webrev.8023563.3/webrev/ Looks good to me. -Chris. > > regards, > Sean. > > On 02/09/13 21:07, Alan Bateman wrote: >> On 02/09/2013 19:06,

Re: RFR :8023563: Bottleneck in java.util.TimeZone.getDefaultInAppContext

2013-09-02 Thread Seán Coffey
Some minor modification (and further simplifying of conditions) : http://cr.openjdk.java.net/~coffeys/webrev.8023563.3/webrev/ regards, Sean. On 02/09/13 21:07, Alan Bateman wrote: On 02/09/2013 19:06, Seán Coffey wrote: This might be a slightly easier one to read. (fast path logic code first

Re: RFR :8023563: Bottleneck in java.util.TimeZone.getDefaultInAppContext

2013-09-02 Thread Alan Bateman
On 02/09/2013 19:06, Seán Coffey wrote: This might be a slightly easier one to read. (fast path logic code first) http://cr.openjdk.java.net/~coffeys/webrev.8023563.2/webrev/ This is nicer (and I see Chris has already pointed out the redundant check). -Alan

Re: RFR :8023563: Bottleneck in java.util.TimeZone.getDefaultInAppContext

2013-09-02 Thread Chris Hegarty
On 2 Sep 2013, at 20:07, Seán Coffey wrote: > Chris - > > you're right on the redundant checks. Had to re-read it! Will get those > removed. Thanks. Otherwise looks fine to me. -Chris. > > regards, > Sean. > > On 02/09/13 19:15, Chris Hegarty wrote: >> On 09/02/2013 07:06 PM, Seán Coffey

Re: RFR :8023563: Bottleneck in java.util.TimeZone.getDefaultInAppContext

2013-09-02 Thread Seán Coffey
Chris - you're right on the redundant checks. Had to re-read it! Will get those removed. Thanks. regards, Sean. On 02/09/13 19:15, Chris Hegarty wrote: On 09/02/2013 07:06 PM, Seán Coffey wrote: This might be a slightly easier one to read. (fast path logic code first) http://cr.openjdk.ja

Re: RFR :8023563: Bottleneck in java.util.TimeZone.getDefaultInAppContext

2013-09-02 Thread Seán Coffey
On 02/09/13 19:15, Chris Hegarty wrote: On 09/02/2013 07:06 PM, Seán Coffey wrote: This might be a slightly easier one to read. (fast path logic code first) http://cr.openjdk.java.net/~coffeys/webrev.8023563.2/webrev/ The 'javaAWTAccess != null ' checks are redundant. It will always be the

Re: RFR :8023563: Bottleneck in java.util.TimeZone.getDefaultInAppContext

2013-09-02 Thread Chris Hegarty
On 09/02/2013 07:06 PM, Seán Coffey wrote: This might be a slightly easier one to read. (fast path logic code first) http://cr.openjdk.java.net/~coffeys/webrev.8023563.2/webrev/ The 'javaAWTAccess != null ' checks are redundant. It will always be the case, right? -Chris. regards, Sean.

Re: RFR :8023563: Bottleneck in java.util.TimeZone.getDefaultInAppContext

2013-09-02 Thread Seán Coffey
This might be a slightly easier one to read. (fast path logic code first) http://cr.openjdk.java.net/~coffeys/webrev.8023563.2/webrev/ regards, Sean. On 02/09/13 16:47, Seán Coffey wrote: Performance regression reported where a high number of threads calling TimeZone.getDefault can run into a

RFR :8023563: Bottleneck in java.util.TimeZone.getDefaultInAppContext

2013-09-02 Thread Seán Coffey
Performance regression reported where a high number of threads calling TimeZone.getDefault can run into a bottleneck on AppContext accessor calls. The bug ID is 8023563 but it's not visible on bugs.sun.com yet. Turns out that we're unnecessarily going through the AppContext in certain scenario