Re: RFR: regex changes

2016-05-03 Thread Xueming Shen
Hi, This one has be out for review for a while. If there is no further comments and feedback the changes will be pushed in shortly. Thanks, Sherman On 3/18/16, 1:05 PM, Xueming Shen wrote: Hi, There are couple regex related changes waiting for review. I have pull them together here (with

Re: RFR: regex changes

2016-03-22 Thread Xueming Shen
Thanks Roger! webrev has been updated accordingly. See comments below. http://cr.openjdk.java.net/~sherman/regexBackTrack.Lamnda.CanonEQ/webrev/ On 03/22/2016 12:48 PM, Roger Riggs wrote: Hi Sherman, A few more comments, Pattern.java: - 1782: typo: "deterministci" fixed. - 2176: commen

Re: RFR: regex changes

2016-03-22 Thread Roger Riggs
Hi Sherman, A few more comments, Pattern.java: - 1782: typo: "deterministci" - 2176: commented out code? - 2667: indentation - 5660,5655: lambda syntax use of simply "ch" is preferred over "(ch)" for single parameter lambdas and for consistency within the file. PrintPattern.java ne

RFR: regex changes

2016-03-19 Thread Xueming Shen
Hi, There are couple regex related changes waiting for review. I have pull them together here (with the notes) to make it easy to review. http://cr.openjdk.java.net/~sherman/regexBackTrack.Lamnda.CanonEQ/webrev/ (1) Exponential backtracking Note: http://cr.openjdk.java.net/~sherman/regexBackT