On Fri, 13 May 2022 16:53:00 GMT, Magnus Ihse Bursie wrote:
>> I ran `codespell` on the `src/java.desktop` directory, and accepted those
>> changes where it indeed discovered real typos.
>>
>> I ignored typos in public methods and variables. Maybe they can be fixed
>> later on without much fan
On Wed, 27 Apr 2022 03:38:09 GMT, Phil Race wrote:
> Please exclude ALL 3rd party libraries from this PR.
Are these the only files to be excluded?
src/java.desktop/share/native/libfreetype/src/autofit/afcjk.c
src/java.desktop/share/native/libfreetype/src/autofit/aflatin.c
src/java.desktop/shar
On Fri, 13 May 2022 16:48:35 GMT, Magnus Ihse Bursie wrote:
>> src/java.desktop/share/classes/sun/swing/text/TextComponentPrintable.java
>> line 772:
>>
>>> 770: /*
>>> 771: * we do not store the same value as previous.
>>> in our
>>> 772:
On Fri, 13 May 2022 16:53:31 GMT, Magnus Ihse Bursie wrote:
>> Nearly 500 files are too many. Smaller chunks would be easier to review.
>>
>> Some of the native code files could come from upstream libraries.
>
> @aivanov-jdk While I approve of finding and fixing spelling mistakes,
> grammatical
On Thu, 28 Apr 2022 21:25:02 GMT, Alexey Ivanov wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with 17
>> additional commits since the last revision:
>>
>> - Update src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java
>>
>>Co-authored-by: Alexey Iv
On Thu, 28 Apr 2022 20:37:22 GMT, Alexey Ivanov wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with 17
>> additional commits since the last revision:
>>
>> - Update src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java
>>
>>Co-authored-by: Alexey Iv
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare, if they are in internal classes. Typos in
> exposed APIs are
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare, if they are in internal classes. Typos in
> exposed APIs are
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare, if they are in internal classes. Typos in
> exposed APIs are
On Thu, 28 Apr 2022 16:48:04 GMT, Alexey Ivanov wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - Update src/java.desktop/share/classes/javax/swing/JLayeredPane.java
>>
>>Co-authored-by: Alexey Ivano
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare, if they are in internal classes. Typos in
> exposed APIs are
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare, if they are in internal classes. Typos in
> exposed APIs are
On Thu, 21 Apr 2022 08:35:36 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare,
On Thu, 21 Apr 2022 08:35:36 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare,
I ran `codespell` on the `src/java.desktop` directory, and accepted those
changes where it indeed discovered real typos.
I ignored typos in public methods and variables. Maybe they can be fixed later
on without much fanfare, if they are in internal classes. Typos in exposed APIs
are likely here
15 matches
Mail list logo
