Re: RFR: 8284856: Add a test case for checking UnicodeScript entity numbers [v3]

2022-04-18 Thread Naoto Sato
> Added the test case, and eliminated the immediate hashmap value, replaced > with the ordinal number of `Character.UnicodeScript.UNKNOWN`. Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits: - Merge branch 'maste

Re: RFR: 8284856: Add a test case for checking UnicodeScript entity numbers [v2]

2022-04-18 Thread openjdk-notifier[bot]
On Thu, 14 Apr 2022 22:27:20 GMT, Naoto Sato wrote: >> Added the test case, and eliminated the immediate hashmap value, replaced >> with the ordinal number of `Character.UnicodeScript.UNKNOWN`. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8284856: Add a test case for checking UnicodeScript entity numbers [v2]

2022-04-14 Thread Stuart Marks
On Thu, 14 Apr 2022 22:27:20 GMT, Naoto Sato wrote: >> Added the test case, and eliminated the immediate hashmap value, replaced >> with the ordinal number of `Character.UnicodeScript.UNKNOWN`. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8284856: Add a test case for checking UnicodeScript entity numbers [v2]

2022-04-14 Thread Iris Clark
On Thu, 14 Apr 2022 22:27:20 GMT, Naoto Sato wrote: >> Added the test case, and eliminated the immediate hashmap value, replaced >> with the ordinal number of `Character.UnicodeScript.UNKNOWN`. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8284856: Add a test case for checking UnicodeScript entity numbers [v2]

2022-04-14 Thread Naoto Sato
> Added the test case, and eliminated the immediate hashmap value, replaced > with the ordinal number of `Character.UnicodeScript.UNKNOWN`. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Fixed a typo - Changes: - all:

Re: RFR: 8284856: Add a test case for checking UnicodeScript entity numbers

2022-04-14 Thread Iris Clark
On Thu, 14 Apr 2022 20:52:44 GMT, Naoto Sato wrote: > Added the test case, and eliminated the immediate hashmap value, replaced > with the ordinal number of `Character.UnicodeScript.UNKNOWN`. Nice catch in the review for 8186958. - Marked as reviewed by iris (Reviewer). PR: https

RFR: 8284856: Add a test case for checking UnicodeScript entity numbers

2022-04-14 Thread Naoto Sato
Added the test case, and eliminated the immediate hashmap value, replaced with the ordinal number of `Character.UnicodeScript.UNKNOWN`. - Depends on: https://git.openjdk.java.net/jdk/pull/7928 Commit messages: - 8284856: Add a test case for checking UnicodeScript entity numbers Ch