On Tue, 1 Feb 2022 09:40:10 GMT, Prasanta Sadhukhan
wrote:
>> The changes done under JDK-8278175 suppress on a per-file basis various
>> missing comments that would otherwise trigger doclint warnings. Fixed them
>> so as to remove the doclint:missing warnings.
>
> Prasanta Sadhukhan has update
> The changes done under JDK-8278175 suppress on a per-file basis various
> missing comments that would otherwise trigger doclint warnings. Fixed them so
> as to remove the doclint:missing warnings.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since t
On Fri, 28 Jan 2022 19:29:14 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comment
>
> src/java.desktop/share/classes/java/awt/Component.java line 4701:
>
>> 4699: *
> The changes done under JDK-8278175 suppress on a per-file basis various
> missing comments that would otherwise trigger doclint warnings. Fixed them so
> as to remove the doclint:missing warnings.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since t
On Mon, 24 Jan 2022 06:03:42 GMT, Prasanta Sadhukhan
wrote:
>> The changes done under JDK-8278175 suppress on a per-file basis various
>> missing comments that would otherwise trigger doclint warnings. Fixed them
>> so as to remove the doclint:missing warnings.
>
> Prasanta Sadhukhan has updat
On Mon, 24 Jan 2022 06:03:42 GMT, Prasanta Sadhukhan
wrote:
>> The changes done under JDK-8278175 suppress on a per-file basis various
>> missing comments that would otherwise trigger doclint warnings. Fixed them
>> so as to remove the doclint:missing warnings.
>
> Prasanta Sadhukhan has updat
On Mon, 24 Jan 2022 06:03:42 GMT, Prasanta Sadhukhan
wrote:
>> The changes done under JDK-8278175 suppress on a per-file basis various
>> missing comments that would otherwise trigger doclint warnings. Fixed them
>> so as to remove the doclint:missing warnings.
>
> Prasanta Sadhukhan has updat
On Mon, 24 Jan 2022 06:03:42 GMT, Prasanta Sadhukhan
wrote:
>> The changes done under JDK-8278175 suppress on a per-file basis various
>> missing comments that would otherwise trigger doclint warnings. Fixed them
>> so as to remove the doclint:missing warnings.
>
> Prasanta Sadhukhan has updat
On Mon, 24 Jan 2022 06:03:42 GMT, Prasanta Sadhukhan
wrote:
>> The changes done under JDK-8278175 suppress on a per-file basis various
>> missing comments that would otherwise trigger doclint warnings. Fixed them
>> so as to remove the doclint:missing warnings.
>
> Prasanta Sadhukhan has updat
On Mon, 24 Jan 2022 11:34:04 GMT, Alexey Ivanov wrote:
>> Since it is mentioned in other places, I would rather not scrap it. Also,
>> since in most places it is mentioned as a non-link value, I chose to modify
>> it.
>
> The `` element does not create a link, it uses monospace font to render
On Mon, 24 Jan 2022 11:28:06 GMT, Prasanta Sadhukhan
wrote:
>> If `ShellFolder` remains mentioned, I'd rather use
>> `ShellFolder` as it was done originally.
>>
>> I guess Sergey challenged the fact of referencing `ShellFolder`. The fact
>> that it could be `ShellFolder` rather than `File` is
On Mon, 24 Jan 2022 10:51:00 GMT, Alexey Ivanov wrote:
>> It is already mentioned in getSystemDisplayName, getSystemTypeDescription,
>> getSystemIcon, isRoot. Anyways, I have removed the linkage for the new
>> addition as it will not be able to resolve.
>
> If `ShellFolder` remains mentioned, I
On Mon, 24 Jan 2022 06:00:02 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java
>> line 353:
>>
>>> 351: * File(parent, fileName) except when the parent and child
>>> are both
>>> 352: * special folders, in which case the Fil
> The changes done under JDK-8278175 suppress on a per-file basis various
> missing comments that would otherwise trigger doclint warnings. Fixed them so
> as to remove the doclint:missing warnings.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since t
On Fri, 21 Jan 2022 07:43:17 GMT, Sergey Bylokhov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix
>
> src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java
> line 353:
>
>> 351:
On Thu, 20 Jan 2022 06:12:29 GMT, Prasanta Sadhukhan
wrote:
>> The changes done under JDK-8278175 suppress on a per-file basis various
>> missing comments that would otherwise trigger doclint warnings. Fixed them
>> so as to remove the doclint:missing warnings.
>
> Prasanta Sadhukhan has updat
On Thu, 20 Jan 2022 06:12:29 GMT, Prasanta Sadhukhan
wrote:
>> The changes done under JDK-8278175 suppress on a per-file basis various
>> missing comments that would otherwise trigger doclint warnings. Fixed them
>> so as to remove the doclint:missing warnings.
>
> Prasanta Sadhukhan has updat
On Thu, 20 Jan 2022 15:11:37 GMT, Alexey Ivanov wrote:
> Shall we indent `serialVersionUID`? It's for `BCSChild` but its indentation
> suggests it's for the surrounding class.
It's right below the class declaration.
-
PR: https://git.openjdk.java.net/jdk/pull/7004
> The changes done under JDK-8278175 suppress on a per-file basis various
> missing comments that would otherwise trigger doclint warnings. Fixed them so
> as to remove the doclint:missing warnings.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since t
> The changes done under JDK-8278175 suppress on a per-file basis various
> missing comments that would otherwise trigger doclint warnings. Fixed them so
> as to remove the doclint:missing warnings.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since t
On Tue, 18 Jan 2022 16:30:07 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review fix
>
> src/java.desktop/share/classes/javax/swing/JScrollBar.java line 120:
>
>> 118: /**
>> 119:
On Mon, 17 Jan 2022 05:26:47 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/undo/UndoableEditSupport.java
>> line 150:
>>
>>> 148:
>>> 149: /**
>>> 150: * Start UndoableEdit.
>>
>> What does it mean? Is it clear enough for the class which "managing
>>
On Mon, 17 Jan 2022 05:31:00 GMT, Prasanta Sadhukhan
wrote:
>> The changes done under JDK-8278175 suppress on a per-file basis various
>> missing comments that would otherwise trigger doclint warnings. Fixed them
>> so as to remove the doclint:missing warnings.
>
> Prasanta Sadhukhan has updat
On Tue, 11 Jan 2022 05:19:56 GMT, Sergey Bylokhov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review fix
>
> src/java.desktop/share/classes/java/awt/BufferCapabilities.java line 65:
>
>> 63:
>> 64:
> The changes done under JDK-8278175 suppress on a per-file basis various
> missing comments that would otherwise trigger doclint warnings. Fixed them so
> as to remove the doclint:missing warnings.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since t
On Mon, 10 Jan 2022 05:25:51 GMT, Prasanta Sadhukhan
wrote:
> The changes done under JDK-8278175 suppress on a per-file basis various
> missing comments that would otherwise trigger doclint warnings. Fixed them so
> as to remove the doclint:missing warnings.
src/java.desktop/share/classes/jav
The changes done under JDK-8278175 suppress on a per-file basis various missing
comments that would otherwise trigger doclint warnings. Fixed them so as to
remove the doclint:missing warnings.
-
Commit messages:
- Fix
- 8278254: Cleanup doclint warnings in java.desktop module
Cha
27 matches
Mail list logo
