Re: RFR: 8277398: javac does not accept encoding name COMPAT [v2]

2021-12-01 Thread Naoto Sato
On Wed, 1 Dec 2021 08:49:09 GMT, Ichiroh Takiguchi wrote: > But it's not easy to pick up right locale/platform encoding name except for > well known users. JEP 400 has the example to get the encoding name as a one liner: java -XshowSettings:properties -version 2>&1 | grep file.encoding (rep

Re: RFR: 8277398: javac does not accept encoding name COMPAT [v2]

2021-12-01 Thread Ichiroh Takiguchi
On Mon, 29 Nov 2021 17:29:03 GMT, Naoto Sato wrote: >> As I explained before, output file encoding which is created by `-Xstdout` >> option is changed to native encoding instead of UTF-8 by >> `-J-Dfile.encoding=COMPAT`. >> In case of Linux ja_JP.eucjp locale, your explanation may be acceptable

Re: RFR: 8277398: javac does not accept encoding name COMPAT [v2]

2021-11-29 Thread Naoto Sato
On Thu, 25 Nov 2021 00:58:47 GMT, Ichiroh Takiguchi wrote: > But how about Windows platform ? If the user specifies `-J-Dfile.encoding=COMPAT`, all operations are done in `MS932` on Japanese Windows. > How can user find encoding name without running java ? I still don't get why the user need

Re: RFR: 8277398: javac does not accept encoding name COMPAT [v2]

2021-11-24 Thread Ichiroh Takiguchi
On Wed, 24 Nov 2021 04:08:43 GMT, Ichiroh Takiguchi wrote: >> ncoding name COMPAT was defined for operating system encoding by JEP-400. >> https://openjdk.java.net/jeps/400 >> But java does not accept "-encoding COMPAT". > > Ichiroh Takiguchi has updated the pull request incrementally with one

Re: RFR: 8277398: javac does not accept encoding name COMPAT [v2]

2021-11-24 Thread Naoto Sato
On Wed, 24 Nov 2021 04:08:43 GMT, Ichiroh Takiguchi wrote: >> ncoding name COMPAT was defined for operating system encoding by JEP-400. >> https://openjdk.java.net/jeps/400 >> But java does not accept "-encoding COMPAT". > > Ichiroh Takiguchi has updated the pull request incrementally with one

Re: RFR: 8277398: javac does not accept encoding name COMPAT [v2]

2021-11-24 Thread Ichiroh Takiguchi
On Wed, 24 Nov 2021 18:35:45 GMT, Naoto Sato wrote: >> Ichiroh Takiguchi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8277398: javac does not accept encoding name COMPAT > > Sorry, but I am kind of lost what you are expecting here. Al

Re: RFR: 8277398: javac does not accept encoding name COMPAT [v2]

2021-11-24 Thread Ichiroh Takiguchi
On Wed, 24 Nov 2021 08:47:54 GMT, Alan Bateman wrote: >> Ichiroh Takiguchi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8277398: javac does not accept encoding name COMPAT > > I see this PR has been re-purposed to add "COMPAT" as a ch

Re: RFR: 8277398: javac does not accept encoding name COMPAT [v2]

2021-11-24 Thread Naoto Sato
On Wed, 24 Nov 2021 04:08:43 GMT, Ichiroh Takiguchi wrote: >> ncoding name COMPAT was defined for operating system encoding by JEP-400. >> https://openjdk.java.net/jeps/400 >> But java does not accept "-encoding COMPAT". > > Ichiroh Takiguchi has updated the pull request incrementally with one

Re: RFR: 8277398: javac does not accept encoding name COMPAT [v2]

2021-11-24 Thread Alan Bateman
On Wed, 24 Nov 2021 04:08:43 GMT, Ichiroh Takiguchi wrote: >> ncoding name COMPAT was defined for operating system encoding by JEP-400. >> https://openjdk.java.net/jeps/400 >> But java does not accept "-encoding COMPAT". > > Ichiroh Takiguchi has updated the pull request incrementally with one

Re: RFR: 8277398: javac does not accept encoding name COMPAT [v2]

2021-11-23 Thread Ichiroh Takiguchi
> ncoding name COMPAT was defined for operating system encoding by JEP-400. > https://openjdk.java.net/jeps/400 > But java does not accept "-encoding COMPAT". Ichiroh Takiguchi has updated the pull request incrementally with one additional commit since the last revision: 8277398: javac does no

Re: RFR: 8277398: javac does not accept encoding name COMPAT

2021-11-23 Thread Jonathan Gibbons
On Fri, 19 Nov 2021 12:11:51 GMT, Alan Bateman wrote: >> ncoding name COMPAT was defined for operating system encoding by JEP-400. >> https://openjdk.java.net/jeps/400 >> But java does not accept "-encoding COMPAT". > > src/jdk.compiler/share/classes/com/sun/tools/javac/file/BaseFileManager.java

Re: RFR: 8277398: javac does not accept encoding name COMPAT

2021-11-22 Thread Ichiroh Takiguchi
On Fri, 19 Nov 2021 07:00:44 GMT, Ichiroh Takiguchi wrote: > ncoding name COMPAT was defined for operating system encoding by JEP-400. > https://openjdk.java.net/jeps/400 > But java does not accept "-encoding COMPAT". Thanks @AlanBateman and @naotoj . I appreciate your good suggestions. My cons

Re: RFR: 8277398: javac does not accept encoding name COMPAT

2021-11-19 Thread Naoto Sato
On Fri, 19 Nov 2021 07:00:44 GMT, Ichiroh Takiguchi wrote: > ncoding name COMPAT was defined for operating system encoding by JEP-400. > https://openjdk.java.net/jeps/400 > But java does not accept "-encoding COMPAT". Do we want this option in `javac`/`javadoc`? Should `-J-Dfile.encoding=COMPAT

Re: RFR: 8277398: javac does not accept encoding name COMPAT

2021-11-19 Thread Alan Bateman
On Fri, 19 Nov 2021 07:00:44 GMT, Ichiroh Takiguchi wrote: > ncoding name COMPAT was defined for operating system encoding by JEP-400. > https://openjdk.java.net/jeps/400 > But java does not accept "-encoding COMPAT". src/jdk.compiler/share/classes/com/sun/tools/javac/file/BaseFileManager.java

RFR: 8277398: javac does not accept encoding name COMPAT

2021-11-18 Thread Ichiroh Takiguchi
ncoding name COMPAT was defined for operating system encoding by JEP-400. https://openjdk.java.net/jeps/400 But java does not accept "-encoding COMPAT". - Commit messages: - 8277398: javac does not accept encoding name COMPAT Changes: https://git.openjdk.java.net/jdk/pull/6475/files