On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote:
> Trivial clean-up.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6110
On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote:
> Trivial clean-up.
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6110
On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote:
> Trivial clean-up.
No, I did not check. I simply removed the `true &&` as it is logically correct.
There's a test specifying `IBM964` in `sun.nio.cs.TestIBMBugs.java`, but not
sure it tests both paths or not.
-
PR: https://git.
On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote:
> Trivial clean-up.
Given that the code has been that way for a *long time*, did you check that
both paths work as intended and that tests exist for both paths?
-
PR: https://git.openjdk.java.net/jdk/pull/6110
On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote:
> Trivial clean-up.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6110
Trivial clean-up.
-
Commit messages:
- 8275767: JDK source code contains redundant boolean operations in
jdk.charsets
Changes: https://git.openjdk.java.net/jdk/pull/6110/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6110&range=00
Issue: https://bugs.openjdk.java.ne
