Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v4]

2021-12-09 Thread Sergey Bylokhov
On Tue, 23 Nov 2021 20:52:40 GMT, Andrey Turbanov wrote: >> 8274893: Update java.desktop classes to use try-with-resources > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8274893: Update java.desktop classes to use try-w

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v4]

2021-11-23 Thread Andrey Turbanov
On Fri, 19 Nov 2021 19:24:50 GMT, Sergey Bylokhov wrote: >> updated > > What about "new InputStreamReader()" here and below? added it to `try` too - PR: https://git.openjdk.java.net/jdk/pull/5817

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v4]

2021-11-23 Thread Andrey Turbanov
> 8274893: Update java.desktop classes to use try-with-resources Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8274893: Update java.desktop classes to use try-with-resources close nested streams too to unify code -

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v3]

2021-11-19 Thread Sergey Bylokhov
On Thu, 18 Nov 2021 18:32:30 GMT, Andrey Turbanov wrote: >> src/java.desktop/share/classes/javax/swing/text/html/HTMLEditorKit.java line >> 463: >> >>> 461: new InputStreamReader(is, ISO_8859_1)); >>> 462: defaultStyles.loadRules(r, null); >>> 463:

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v3]

2021-11-18 Thread Andrey Turbanov
On Thu, 18 Nov 2021 05:36:29 GMT, Sergey Bylokhov wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8274893: Update java.desktop classes to use try-with-resources >> fix review comments > > src/java.desktop/shar

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v3]

2021-11-18 Thread Andrey Turbanov
> 8274893: Update java.desktop classes to use try-with-resources Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8274893: Update java.desktop classes to use try-with-resources fix review comments - Changes: - all:

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v2]

2021-11-18 Thread Andrey Turbanov
On Thu, 18 Nov 2021 05:30:59 GMT, Sergey Bylokhov wrote: >> Andrey Turbanov has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8274893: Update java.desktop classes to use try-with-resources >>close nested resources too >> - [PATCH] U

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v2]

2021-11-17 Thread Sergey Bylokhov
On Wed, 13 Oct 2021 07:35:16 GMT, Andrey Turbanov wrote: >> 8274893: Update java.desktop classes to use try-with-resources > > Andrey Turbanov has updated the pull request incrementally with two > additional commits since the last revision: > > - 8274893: Update java.desktop classes to use try

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v2]

2021-10-13 Thread Andrey Turbanov
On Tue, 12 Oct 2021 06:16:00 GMT, Sergey Bylokhov wrote: >> Andrey Turbanov has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8274893: Update java.desktop classes to use try-with-resources >>close nested resources too >> - [PATCH] U

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v2]

2021-10-13 Thread Andrey Turbanov
> 8274893: Update java.desktop classes to use try-with-resources Andrey Turbanov has updated the pull request incrementally with two additional commits since the last revision: - 8274893: Update java.desktop classes to use try-with-resources close nested resources too - [PATCH] Use try-with

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources

2021-10-11 Thread Sergey Bylokhov
On Tue, 5 Oct 2021 08:13:53 GMT, Andrey Turbanov wrote: > 8274893: Update java.desktop classes to use try-with-resources src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java line 587: > 585: // Pending: verify character encoding spec for gconf > 586:

RFR: 8274893: Update java.desktop classes to use try-with-resources

2021-10-07 Thread Andrey Turbanov
8274893: Update java.desktop classes to use try-with-resources - Commit messages: - [PATCH] Use try-with-resources to close resources in java.desktop - [PATCH] Use try-with-resources to close resources in java.desktop - [PATCH] Use try-with-resources to close InputStream in java.de