On Mon, 30 Aug 2021 15:52:05 GMT, Ian Graves wrote:
>> 8271302: Regex Test Refresh
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing some notes re JUnit5
https://bugs.openjdk.java.net/browse/JDK-8273169
I'd like to fi
On Mon, 30 Aug 2021 15:52:05 GMT, Ian Graves wrote:
>> 8271302: Regex Test Refresh
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing some notes re JUnit5
Looks like it was missed that the test fails oi a github action
> 8271302: Regex Test Refresh
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Removing some notes re JUnit5
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5092/files
- new: https://git.openjdk.java.net/jdk/pul
On Fri, 27 Aug 2021 23:18:34 GMT, Stuart Marks wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Additional cleanup
>
> test/jdk/java/util/regex/RegExTest.java line 85:
>
>> 83: import static org.testng.Assert.fail;
>
On Fri, 20 Aug 2021 21:17:50 GMT, Ian Graves wrote:
>> 8271302: Regex Test Refresh
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Additional cleanup
Marked as reviewed by smarks (Reviewer).
Whew! Changes to GraphemeTest.ja
> 8271302: Regex Test Refresh
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Additional cleanup
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5092/files
- new: https://git.openjdk.java.net/jdk/pull/5092/file
On Fri, 20 Aug 2021 16:49:15 GMT, Pavel Rappo wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> some quick fixes
>
> test/jdk/java/util/regex/RegExTest.java line 4270:
>
>> 4268: String s = (String)pm[1];
On Fri, 20 Aug 2021 16:27:53 GMT, Ian Graves wrote:
>> 8271302: Regex Test Refresh
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> some quick fixes
test/jdk/java/util/regex/RegExTest.java line 4270:
> 4268: Stri
> 8271302: Regex Test Refresh
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
some quick fixes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5092/files
- new: https://git.openjdk.java.net/jdk/pull/5092/files/
On Fri, 20 Aug 2021 13:32:24 GMT, Pavel Rappo wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Couple of fixes
>
> test/jdk/java/util/regex/NegativeArraySize.java line 29:
>
>> 27: * @summary Pattern.compile() can t
On Fri, 20 Aug 2021 13:46:39 GMT, Pavel Rappo wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Couple of fixes
>
> test/jdk/java/util/regex/NegativeArraySize.java line 40:
>
>> 38: @Test
>> 39: public static
On Wed, 18 Aug 2021 18:35:53 GMT, Ian Graves wrote:
>> 8271302: Regex Test Refresh
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Couple of fixes
test/jdk/java/util/regex/NegativeArraySize.java line 2:
> 1: /*
> 2: * Copy
On Wed, 18 Aug 2021 18:35:53 GMT, Ian Graves wrote:
>> 8271302: Regex Test Refresh
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Couple of fixes
Marked as reviewed by bchristi (Reviewer).
-
PR: https://git.op
On Fri, 13 Aug 2021 20:17:56 GMT, Brent Christian wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Couple of fixes
>
> test/jdk/java/util/regex/RegExTest.java line 3952:
>
>> 3950:
>> 3951: m = Pattern.c
> 8271302: Regex Test Refresh
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Couple of fixes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5092/files
- new: https://git.openjdk.java.net/jdk/pull/5092/files/1
On Fri, 13 Aug 2021 20:16:22 GMT, Brent Christian wrote:
>> 8271302: Regex Test Refresh
>
> test/jdk/java/util/regex/RegExTest.java line 2362:
>
>> 2360:
>> 2361: { "test\ud834\uddc0", "test\ud834\uddc0",
>>"m", true },
>> 2362: //{ "test\ud834\uddbc\ud
On Wed, 11 Aug 2021 18:22:42 GMT, Ian Graves wrote:
> 8271302: Regex Test Refresh
Changes requested by bchristi (Reviewer).
In the JBS issue, it looks like the Description was put in the Environment. :)
test/jdk/java/util/regex/RegExTest.java line 291:
> 289:
> 290: int resultStart1
8271302: Regex Test Refresh
-
Commit messages:
- Migrating regular expression tests to TestNG
Changes: https://git.openjdk.java.net/jdk/pull/5092/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5092&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8271302
St
On Wed, 11 Aug 2021 18:22:42 GMT, Ian Graves wrote:
> 8271302: Regex Test Refresh
This PR migrates all regular expression tests in the jdk/java/util/regex
directory to use TestNG assertions and annotations. The assertions utilized for
this refresh are shared in common with standard ones from J
19 matches
Mail list logo
