Re: RFR: 8268113: Re-use Long.hashCode() where possible [v11]

2021-08-02 Thread Claes Redestad
On Mon, 26 Jul 2021 08:27:14 GMT, Сергей Цыпанов wrote: >> There is a few JDK classes duplicating the contents of Long.hashCode() for >> hash code calculation. They should explicitly delegate to Long.hashCode(). > > Сергей Цыпанов has updated the pull request with a new target base due to a >

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v11]

2021-07-26 Thread Сергей Цыпанов
> There is a few JDK classes duplicating the contents of Long.hashCode() for > hash code calculation. They should explicitly delegate to Long.hashCode(). Сергей Цыпанов has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated c

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v10]

2021-07-14 Thread Сергей Цыпанов
> There is a few JDK classes duplicating the contents of Long.hashCode() for > hash code calculation. They should explicitly delegate to Long.hashCode(). Сергей Цыпанов has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated c

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v9]

2021-07-14 Thread Сергей Цыпанов
On Tue, 13 Jul 2021 13:04:36 GMT, Attila Szegedi wrote: >> src/java.base/share/classes/java/util/BitSet.java line 1040: >> >>> 1038: h ^= words[i] * (i + 1); >>> 1039: >>> 1040: return Long.hashCode(h); >> >> Here `>>` instead of `>>>` in original code seems to be a typo >

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v9]

2021-07-13 Thread Attila Szegedi
On Wed, 2 Jun 2021 14:11:07 GMT, Сергей Цыпанов wrote: >> Сергей Цыпанов has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains ten additional >> comm

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v9]

2021-07-08 Thread Сергей Цыпанов
> There is a few JDK classes duplicating the contents of Long.hashCode() for > hash code calculation. They should explicitly delegate to Long.hashCode(). Сергей Цыпанов has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated c

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v8]

2021-06-30 Thread Сергей Цыпанов
> There is a few JDK classes duplicating the contents of Long.hashCode() for > hash code calculation. They should explicitly delegate to Long.hashCode(). Сергей Цыпанов has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated c

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v7]

2021-06-10 Thread Сергей Цыпанов
> There is a few JDK classes duplicating the contents of Long.hashCode() for > hash code calculation. They should explicitly delegate to Long.hashCode(). Сергей Цыпанов has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated c

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v6]

2021-06-09 Thread Сергей Цыпанов
> There is a few JDK classes duplicating the contents of Long.hashCode() for > hash code calculation. They should explicitly delegate to Long.hashCode(). Сергей Цыпанов has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated c

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v5]

2021-06-08 Thread Сергей Цыпанов
> There is a few JDK classes duplicating the contents of Long.hashCode() for > hash code calculation. They should explicitly delegate to Long.hashCode(). Сергей Цыпанов has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated c

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v4]

2021-06-04 Thread Сергей Цыпанов
> There is a few JDK classes duplicating the contents of Long.hashCode() for > hash code calculation. They should explicitly delegate to Long.hashCode(). Сергей Цыпанов has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated c

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v3]

2021-06-02 Thread Сергей Цыпанов
On Wed, 2 Jun 2021 17:58:29 GMT, Vyom Tewari wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268113: Inline local vars where reasonable > > src/java.base/share/classes/java/util/BitSet.java line 105: > >> 103:

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v3]

2021-06-02 Thread Vyom Tewari
On Wed, 2 Jun 2021 16:37:49 GMT, Сергей Цыпанов wrote: >> There is a few JDK classes duplicating the contents of Long.hashCode() for >> hash code calculation. They should explicitly delegate to Long.hashCode(). > > Сергей Цыпанов has updated the pull request incrementally with one additional >

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v3]

2021-06-02 Thread Сергей Цыпанов
On Wed, 2 Jun 2021 14:50:23 GMT, liach wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268113: Inline local vars where reasonable > > src/java.base/share/classes/java/lang/Double.java line 881: > >> 879: p

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v3]

2021-06-02 Thread Сергей Цыпанов
> There is a few JDK classes duplicating the contents of Long.hashCode() for > hash code calculation. They should explicitly delegate to Long.hashCode(). Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision: 8268113: Inline local vars wh

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v2]

2021-06-02 Thread Сергей Цыпанов
On Wed, 2 Jun 2021 14:51:35 GMT, liach wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268113: Delegate to Double.hashCode() > > src/java.desktop/macosx/classes/apple/laf/JRSUIConstants.java line 115: > >> 113

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v2]

2021-06-02 Thread Сергей Цыпанов
> There is a few JDK classes duplicating the contents of Long.hashCode() for > hash code calculation. They should explicitly delegate to Long.hashCode(). Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision: 8268113: Delegate to Double.h

Re: RFR: 8268113: Re-use Long.hashCode() where possible

2021-06-02 Thread liach
On Wed, 2 Jun 2021 14:10:38 GMT, Сергей Цыпанов wrote: > There is a few JDK classes duplicating the contents of Long.hashCode() for > hash code calculation. They should explicitly delegate to Long.hashCode(). src/java.base/share/classes/java/lang/Double.java line 881: > 879: public static

Re: RFR: 8268113: Re-use Long.hashCode() where possible

2021-06-02 Thread Сергей Цыпанов
On Wed, 2 Jun 2021 14:10:38 GMT, Сергей Цыпанов wrote: > There is a few JDK classes duplicating the contents of Long.hashCode() for > hash code calculation. They should explicitly delegate to Long.hashCode(). src/java.base/share/classes/java/util/BitSet.java line 1040: > 1038: h ^

RFR: 8268113: Re-use Long.hashCode() where possible

2021-06-02 Thread Сергей Цыпанов
There is a few JDK classes duplicating the contents of Long.hashCode() for hash code calculation. They should explicitly delegate to Long.hashCode(). - Commit messages: - 8268113: Re-use Long.hashCode() where possible Changes: https://git.openjdk.java.net/jdk/pull/4309/files Webre