Re: RFR: 8261728: SimpleDateFormat should link to DateTimeFormatter [v2]

2021-02-18 Thread Roger Riggs
On Wed, 17 Feb 2021 20:21:57 GMT, Naoto Sato wrote: >> Please review this simple doc fix. A CSR will be filed accordingly. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Made the additional text an @apiNote Marked as review

Re: RFR: 8261728: SimpleDateFormat should link to DateTimeFormatter [v2]

2021-02-17 Thread Iris Clark
On Wed, 17 Feb 2021 20:21:57 GMT, Naoto Sato wrote: >> Please review this simple doc fix. A CSR will be filed accordingly. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Made the additional text an @apiNote Marked as review

Re: RFR: 8261728: SimpleDateFormat should link to DateTimeFormatter [v2]

2021-02-17 Thread Naoto Sato
On Wed, 17 Feb 2021 20:04:33 GMT, Lance Andersen wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Made the additional text an @apiNote > > Hi Naoto, > > Looks good. > > Any thoughts to making the new wording stick

Re: RFR: 8261728: SimpleDateFormat should link to DateTimeFormatter [v2]

2021-02-17 Thread Lance Andersen
On Wed, 17 Feb 2021 20:18:56 GMT, Naoto Sato wrote: >> Please review this simple doc fix. A CSR will be filed accordingly. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Made the additional text an @apiNote Marked as review

Re: RFR: 8261728: SimpleDateFormat should link to DateTimeFormatter [v2]

2021-02-17 Thread Naoto Sato
> Please review this simple doc fix. A CSR will be filed accordingly. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Made the additional text an @apiNote - Changes: - all: https://git.openjdk.java.net/jdk/pull/2616/file

Re: RFR: 8261728: SimpleDateFormat should link to DateTimeFormatter [v2]

2021-02-17 Thread Brian Burkhalter
On Wed, 17 Feb 2021 20:18:56 GMT, Naoto Sato wrote: >> Please review this simple doc fix. A CSR will be filed accordingly. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Made the additional text an @apiNote Marked as review

Re: RFR: 8261728: SimpleDateFormat should link to DateTimeFormatter

2021-02-17 Thread Roger Riggs
On Wed, 17 Feb 2021 19:34:47 GMT, Naoto Sato wrote: > Please review this simple doc fix. A CSR will be filed accordingly. Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2616

Re: RFR: 8261728: SimpleDateFormat should link to DateTimeFormatter

2021-02-17 Thread Lance Andersen
On Wed, 17 Feb 2021 19:34:47 GMT, Naoto Sato wrote: > Please review this simple doc fix. A CSR will be filed accordingly. Hi Naoto, Looks good. Any thoughts to making the new wording stick out more perhaps via a something like "Note: Consider" and bolding "Note:" Not sure if it is @

Re: RFR: 8261728: SimpleDateFormat should link to DateTimeFormatter

2021-02-17 Thread Brian Burkhalter
On Wed, 17 Feb 2021 19:34:47 GMT, Naoto Sato wrote: > Please review this simple doc fix. A CSR will be filed accordingly. LGTM - Marked as reviewed by bpb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2616

RFR: 8261728: SimpleDateFormat should link to DateTimeFormatter

2021-02-17 Thread Naoto Sato
Please review this simple doc fix. A CSR will be filed accordingly. - Commit messages: - 8261728: SimpleDateFormat should link to DateTimeFormatter Changes: https://git.openjdk.java.net/jdk/pull/2616/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2616&range=00 Issue: