Re: RFR: 8259522: Apply java.io.Serial annotations in java.desktop [v2]

2021-01-12 Thread Prasanta Sadhukhan
On Tue, 12 Jan 2021 20:42:18 GMT, Sergey Bylokhov wrote: >> Please review the application of @java.io.Serial annotation (JDK-8202385) to >> types in the desktop module to enable stricter compile-time checking of >> serialization-related declarations. >> >> This annotation can be applied to the

Re: RFR: 8259522: Apply java.io.Serial annotations in java.desktop [v2]

2021-01-12 Thread Sergey Bylokhov
On Wed, 13 Jan 2021 06:10:53 GMT, Prasanta Sadhukhan wrote: > Why do we add serialVersionUID in some classes like > DefaultMutableTreeNode.java but not in other swing classes? Most Swing classes are marked by the specific "Warning" that "Same-version serialization only" is supported. (I think

Re: RFR: 8259522: Apply java.io.Serial annotations in java.desktop [v2]

2021-01-12 Thread Prasanta Sadhukhan
On Tue, 12 Jan 2021 20:42:18 GMT, Sergey Bylokhov wrote: >> Please review the application of @java.io.Serial annotation (JDK-8202385) to >> types in the desktop module to enable stricter compile-time checking of >> serialization-related declarations. >> >> This annotation can be applied to the

Re: RFR: 8259522: Apply java.io.Serial annotations in java.desktop [v2]

2021-01-12 Thread Alexey Ivanov
On Tue, 12 Jan 2021 20:36:21 GMT, Sergey Bylokhov wrote: >> src/java.desktop/share/classes/com/sun/media/sound/InvalidDataException.java >> line 42: >> >>> 40: */ >>> 41: @Serial >>> 42: private static final long serialVersionUID = 1L; >> >> This is the standard wording, yet shoul

Re: RFR: 8259522: Apply java.io.Serial annotations in java.desktop [v2]

2021-01-12 Thread Sergey Bylokhov
> Please review the application of @java.io.Serial annotation (JDK-8202385) to > types in the desktop module to enable stricter compile-time checking of > serialization-related declarations. > > This annotation can be applied to these methods in the module: > > private void writeObject(java

Re: RFR: 8259522: Apply java.io.Serial annotations in java.desktop [v2]

2021-01-12 Thread Sergey Bylokhov
On Tue, 12 Jan 2021 11:29:24 GMT, Alexey Ivanov wrote: >> Sergey Bylokhov has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update >> src/java.desktop/share/classes/java/awt/image/ImagingOpException.java >> >>Co-authored-by: Ale

Re: RFR: 8259522: Apply java.io.Serial annotations in java.desktop

2021-01-12 Thread Alexey Ivanov
On Mon, 11 Jan 2021 06:21:52 GMT, Sergey Bylokhov wrote: > Please review the application of @java.io.Serial annotation (JDK-8202385) to > types in the desktop module to enable stricter compile-time checking of > serialization-related declarations. > > This annotation can be applied to these me

RFR: 8259522: Apply java.io.Serial annotations in java.desktop

2021-01-11 Thread Sergey Bylokhov
Please review the application of @java.io.Serial annotation (JDK-8202385) to types in the desktop module to enable stricter compile-time checking of serialization-related declarations. This annotation can be applied to these methods in the module: private void writeObject(java.io.ObjectOutp