Re: RFR: 8255086: Update the root locale display names [v2]

2020-10-22 Thread Joe Wang
On Wed, 21 Oct 2020 23:38:23 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the changes to the subject issue. The fix replaces the >> obsolete/incorrect English language/region/script display names in the >> COMPAT root locale bundle. The data are derived from CLDR's English names. > > Naot

Re: RFR: 8255086: Update the root locale display names [v2]

2020-10-22 Thread Joe Wang
On Thu, 22 Oct 2020 23:20:08 GMT, Naoto Sato wrote: > Hi Joe, > > > Do we need a test similar to ISO3166 where display names of Locale.ROOT and > > Locale.US are compared? I see LocaleEnhanceTest.java has references to > > Locale.ROOT and a few selected names were updated. But we don't seem to

Re: RFR: 8255086: Update the root locale display names [v2]

2020-10-22 Thread Naoto Sato
On Thu, 22 Oct 2020 22:29:16 GMT, Joe Wang wrote: >> Marked as reviewed by bchristi (Reviewer). > > Hi Naoto, > > Do we need a test similar to ISO3166 where display names of Locale.ROOT and > Locale.US are compared? I see LocaleEnhanceTest.java has references to > Locale.ROOT and a few selecte

Re: RFR: 8255086: Update the root locale display names [v2]

2020-10-22 Thread Joe Wang
On Thu, 22 Oct 2020 21:40:59 GMT, Brent Christian wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Put a newline at the end. > > Marked as reviewed by bchristi (Reviewer). Hi Naoto, Do we need a test similar to ISO3

Re: RFR: 8255086: Update the root locale display names [v2]

2020-10-22 Thread Brent Christian
On Wed, 21 Oct 2020 23:38:23 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the changes to the subject issue. The fix replaces the >> obsolete/incorrect English language/region/script display names in the >> COMPAT root locale bundle. The data are derived from CLDR's English names. > > Naot

Re: RFR: 8255086: Update the root locale display names [v2]

2020-10-21 Thread Naoto Sato
> Hi, > > Please review the changes to the subject issue. The fix replaces the > obsolete/incorrect English language/region/script display names in the COMPAT > root locale bundle. The data are derived from CLDR's English names. Naoto Sato has updated the pull request incrementally with one add