Re: Maybe some not useful code in sun.awt.im.InputContext

2011-12-06 Thread Naoto Sato
The code in question was introduced with this RFE: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4293626 I don't think we have automated regression tests for this one. Test team might have some manual tests, but not sure as this is very old code. Sorry. Naoto On 12/5/11 6:33 PM, Charles

Re: Maybe some not useful code in sun.awt.im.InputContext

2011-12-05 Thread Charles Lee
On 12/06/2011 03:16 AM, Naoto Sato wrote: Hi Charles, Even though your finding below sounds right, I would not remove that piece of code, unless we are sure that it would not cause any regression. Naoto On 12/2/11 9:45 AM, Neil Richards wrote: On Fri, 2011-12-02 at 16:53 +0800, Charles Lee

Re: Maybe some not useful code in sun.awt.im.InputContext

2011-12-05 Thread Naoto Sato
Hi Charles, Even though your finding below sounds right, I would not remove that piece of code, unless we are sure that it would not cause any regression. Naoto On 12/2/11 9:45 AM, Neil Richards wrote: On Fri, 2011-12-02 at 16:53 +0800, Charles Lee wrote: Hi guys, I am doing some code read

Re: Maybe some not useful code in sun.awt.im.InputContext

2011-12-02 Thread Neil Richards
On Fri, 2011-12-02 at 16:53 +0800, Charles Lee wrote: > Hi guys, > > I am doing some code reading through the input method framework. Once I > meet sun.awt.im.InputContext, I find the code (line 228), it says: > > // Ignore focus events that relate to the InputMethodWindow of this > context. >