Hi Alan,
The change is not for upgrading the currency data in generated run-time
images, rather we see no reason of keeping it inside java.base. The
currency data updation process is separate task and each time an
ISO-4217 amendment version is released, the updation process should not
modify
On 09/06/2017 07:59, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8176583
Bug: https://bugs.openjdk.java.net/browse/JDK-8176583
Webrev: http://cr.openjdk.java.net/~nishjain/8176583/webrev.01/
Fix: Relocated currency.data from java.base module
(/java.base/java/util/currency.data) to
Looks good.
Naoto
On 6/12/17 2:01 AM, Nishit Jain wrote:
Thanks Naoto,
Please check the updated webrev
http://cr.openjdk.java.net/~nishjain/8176583/webrev.02/
Changes:
- merged the try blocks in Currency.java
- replaced the try block in CheckDataVersion.java with try-with-resource
and a smal
Thanks Naoto,
Please check the updated webrev
http://cr.openjdk.java.net/~nishjain/8176583/webrev.02/
Changes:
- merged the try blocks in Currency.java
- replaced the try block in CheckDataVersion.java with try-with-resource
and a small indentation change at line 82.
Regards,
Nishit Jain
On 0
Hi Nishit,
In Currency.java, there seems to be a redundant try block (line 206). Is
it possible to merge it with the try block at line 205?
Otherwise it looks good to me.
Naoto
On 6/8/17 11:59 PM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8176583
Bug: https://bugs.openjdk.java.
Hi,
Please review the fix for JDK-8176583
Bug: https://bugs.openjdk.java.net/browse/JDK-8176583
Webrev: http://cr.openjdk.java.net/~nishjain/8176583/webrev.01/
Fix: Relocated currency.data from java.base module
(/java.base/java/util/currency.data) to /lib directory
Regards,
Nishit Jain
