Re: 8027848: The ZoneInfoFile doesn't honor future GMT offset changes

2013-11-15 Thread Seán Coffey
Looks good here too Aleksej.. in case you need a second reviewer. regards, Sean. On 06/11/2013 17:18, Xueming Shen wrote: Looks fine. thanks! -Sherman On 11/05/2013 03:21 PM, Aleksej Efimov wrote: Sherman, Thank you for a quick review. I totally agree with you on all items. Actually, I misse

Re: 8027848: The ZoneInfoFile doesn't honor future GMT offset changes

2013-11-06 Thread Aleksej Efimov
Sherman, thank you for reviewing it! -Aleksej On 11/06/2013 09:18 PM, Xueming Shen wrote: Looks fine. thanks! -Sherman On 11/05/2013 03:21 PM, Aleksej Efimov wrote: Sherman, Thank you for a quick review. I totally agree with you on all items. Actually, I missed fact that the transitions are

Re: 8027848: The ZoneInfoFile doesn't honor future GMT offset changes

2013-11-06 Thread Xueming Shen
Looks fine. thanks! -Sherman On 11/05/2013 03:21 PM, Aleksej Efimov wrote: Sherman, Thank you for a quick review. I totally agree with you on all items. Actually, I missed fact that the transitions are sorted. And yes - the change can be done on line #431. The new tested fix can be found here

Re: 8027848: The ZoneInfoFile doesn't honor future GMT offset changes

2013-11-05 Thread Aleksej Efimov
Sherman, Thank you for a quick review. I totally agree with you on all items. Actually, I missed fact that the transitions are sorted. And yes - the change can be done on line #431. The new tested fix can be found here: http://cr.openjdk.java.net/~aefimov/8027848/webrev.01/

Re: 8027848: The ZoneInfoFile doesn't honor future GMT offset changes

2013-11-05 Thread Xueming Shen
On 11/05/2013 10:50 AM, Xueming Shen wrote: Aleksej, For better performance (1) the currT should be "static final" so we dont have to access the System.curentTimeMillis() for each TimeZone/ZoneInfo instance. (2) instead of iterating through the standardTransitions(), shouldn't we just check the

Re: 8027848: The ZoneInfoFile doesn't honor future GMT offset changes

2013-11-05 Thread Xueming Shen
Aleksej, For better performance (1) the currT should be "static final" so we dont have to access the System.curentTimeMillis() for each TimeZone/ZoneInfo instance. (2) instead of iterating through the standardTransitions(), shouldn't we just check the last one? given it's a sorted list. btw, in

Re: 8027848: The ZoneInfoFile doesn't honor future GMT offset changes

2013-11-05 Thread Alan Bateman
Adding i18n-dev as this is the mailing list where this area is maintained. On 05/11/2013 17:26, Aleksej Efimov wrote: Hi, Can I have a review for a 8027848 [1] bug fix . There is unimplemented functionality related to the future GMT offset changes. The ZoneInfoFile class doesn't analyses if th