Re: RFR: X11 default visual support for IM status window on VNC

2019-01-29 Thread Sergey Bylokhov
Looks fine, if there are no other comments I'll push the fix this week. On 21/01/2019 20:08, Ichiroh Takiguchi wrote: Hello Sergey. Sorry, code conflict was there. I fixed code conflict and modified Copyright year. Could you review the fix again ? Bug:    https://bugs.openjdk.java.net/browse

Re: RFR: X11 default visual support for IM status window on VNC

2019-01-21 Thread Ichiroh Takiguchi
Hello Sergey. Sorry, code conflict was there. I fixed code conflict and modified Copyright year. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212677 Change: https://cr.openjdk.java.net/~itakiguchi/8212677/webrev.01/ Thanks, Ichiroh Takiguchi IBM Japan, Ltd

Re: RFR: X11 default visual support for IM status window on VNC

2018-11-30 Thread Sergey Bylokhov
Looks fine, if there are no other comments I'll push the fix. On 26/11/2018 05:02, Ichiroh Takiguchi wrote: Hello. Could you review the fix ? Bug:    https://bugs.openjdk.java.net/browse/JDK-8212677 Change: https://cr.openjdk.java.net/~itakiguchi/8212677/webrev.00/ Screen shots are in JDK-821

RFR: X11 default visual support for IM status window on VNC

2018-11-26 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212677 Change: https://cr.openjdk.java.net/~itakiguchi/8212677/webrev.00/ Screen shots are in JDK-8212677. I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-06-21