Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

This version looks fine. On 28/04/2019 20:47, Ichiroh Takiguchi wrote: Hello. I built the new fixed code by GCC 8.2.1. It worked fine. Thanks, Ichiroh Takiguchi On 2019-04-26 23:04, Ichiroh Takiguchi wrote: Hello Sergey. See "Preedit State Callbacks" section on Xlib manual [1] Return code f

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

Hello. I built the new fixed code by GCC 8.2.1. It worked fine. Thanks, Ichiroh Takiguchi On 2019-04-26 23:04, Ichiroh Takiguchi wrote: Hello Sergey. See "Preedit State Callbacks" section on Xlib manual [1] Return code for PreeditStartCallback should be int instead of void: int PreeditStartCa

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

Hello Sergey. See "Preedit State Callbacks" section on Xlib manual [1] Return code for PreeditStartCallback should be int instead of void: int PreeditStartCallback(XIC ic, XPointer client_data, XPointer call_data); I'm very sorry, I could not create build environment for GCC 8.2 on today. S

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

Hi, Ichiroh. I got this build error when I tried to test this patch: open/src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c:83:5: error: cast between incompatible function types from 'int (*)(struct >..._XIC *, char *, char *)' to 'void (*)(struct _XIM *, char *, char *)' [-Werro

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

On 18/04/2019 04:09, Ichiroh Takiguchi wrote: Should I remove "defined(MACOSX)" from awt_InputMethod.c or just modified code ? Please give me your suggestion. Ok, looks fine. Lets move cleanup of "defined(MACOSX)" in the xawt to some separate task. -- Best regards, Sergey.

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

Hello Sergey. Sorry for bad response. About "defined(MACOSX)" I followed Line# 87 usage, because the codes handle IME status windows. 82 static XIMProc callback_funcs[NCALLBACKS] = { 83 (XIMProc)PreeditStartCallback, 84 (XIMProc)PreeditDoneCallback, 85 (XIMProc)PreeditDrawCa

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

Hi, Ichiroh. Why the fix uses the "defined(MACOSX)" in a few places? I assume this code is never executed on macOS. Should we update the aix version as well? .../java.desktop/aix/native/libawt_xawt/awt/awt_InputMethod.c On 25/03/2019 09:28, Ichiroh Takiguchi wrote: Hello. Could you review the

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

Hello. Could you review the fix and give me your suggestion, please ? I really appreciate your feedback. Currently, UnsupportedOperationException happens because of invalid usage by input method operation. And I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi On 2019-03

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

Hello. Could you review the fix and give me your suggestion, please ? Thanks, Ichiroh Takiguchi On 2019-02-26 22:08, Ichiroh Takiguchi wrote: Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8213232 Change: https://cr.openjdk.java.net/~itakiguchi/8213232/web

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8213232 Change: https://cr.openjdk.java.net/~itakiguchi/8213232/webrev.01/ JDK-8213232 [1] has movies. Please check it. I applied following changes on webrev.01: 1. According to "Xlib - C Language X Interface" [

RFR: 8213232 Unix/X11 setCompositionEnableNative issue

Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8213232 Change: https://cr.openjdk.java.net/~itakiguchi/8213232/webrev.00/ This issue is related by wrong usage of XNPreeditState on XSetICValues(). Because of wrong usage, UnsupportedOperationException exceptio