Re: Add some missing key maps

2012-06-07 Thread Charles Lee
Hi Anthony, 1) Will do 2) Need environment. Will do later 3) Will check that. On 06/07/2012 09:12 PM, Anthony Petrov wrote: Hi Charles, Thanks for pushing this fix. However, we had an internal discussion, and here's a few comments regarding it (I'm CC'ing Yuri who provided the comments): On

Re: Add some missing key maps

2012-06-07 Thread Anthony Petrov
Hi Charles, Thanks for pushing this fix. However, we had an internal discussion, and here's a few comments regarding it (I'm CC'ing Yuri who provided the comments): On 06/07/2012 10:53 AM, Yuri Nesterenko wrote: (1) XKeysym.java is a generated file; I'd make change in keysym2ucs.h instead,

Re: Add some missing key maps

2012-06-06 Thread Charles Lee
Thank you Naoto. The patch has been committed. On 06/07/2012 12:45 AM, Naoto Sato wrote: I double checked your patch and confirmed that the table lookup comes after those KANA specific handling, so it looks ok to me. Naoto On 6/5/12 8:13 PM, Charles Lee wrote: Thank you Naoto. Thank you Anth

Re: Add some missing key maps

2012-06-06 Thread Naoto Sato
I double checked your patch and confirmed that the table lookup comes after those KANA specific handling, so it looks ok to me. Naoto On 6/5/12 8:13 PM, Charles Lee wrote: Thank you Naoto. Thank you Anthony. I do not see the problem. Would some solaris guys take a look on this issue? On 06/0

Re: Add some missing key maps

2012-06-05 Thread Charles Lee
Thank you Naoto. Thank you Anthony. I do not see the problem. Would some solaris guys take a look on this issue? On 06/06/2012 01:56 AM, Naoto Sato wrote: The patch is changing the code to always convert VK_KANA_LOCK to XK_Kana_Lock keysym. Does this work with Solaris? Looks like there are som

Re: Add some missing key maps

2012-06-05 Thread Naoto Sato
The patch is changing the code to always convert VK_KANA_LOCK to XK_Kana_Lock keysym. Does this work with Solaris? Looks like there are some piece of code that specifically handles KANA_LOCK. Naoto On 6/5/12 9:02 AM, Anthony Petrov wrote: Hi Charles, I'm not an expert in keyboard-related cod

Re: Add some missing key maps

2012-06-05 Thread Anthony Petrov
Hi Charles, I'm not an expert in keyboard-related code, but the code changes look good to me. I think I18n team might want to take a look at the fix as well, so I'm CC'ing the i18n-dev@ mailing list. -- best regards, Anthony On 6/5/2012 7:19 AM, Charles Lee wrote: Hi awt-devs, There ar