Re: [8] Review request for 7196354 check-in jdk.tbom file to openjdk repo

Thanks Mark for the comment. Yes, we will do that. thanks, -michael On 12年09月11日 08:09 上午, mark.reinh...@oracle.com wrote: 2012/9/10 14:26 -0700, michael.f...@oracle.com: I have updated the webrev: http://cr.openjdk.java.net/~mfang/7196354/webrev.01/ ... I am also moving the file from root

Re: [8] Review request for 7196354 check-in jdk.tbom file to openjdk repo

2012/9/10 14:26 -0700, michael.f...@oracle.com: > I have updated the webrev: > http://cr.openjdk.java.net/~mfang/7196354/webrev.01/ > > ... > > I am also moving the file from root of source tree to > jdk/make/jdk.tbom. SGT strongly recommends we follow the standard file > naming convention used b

Re: [8] Review request for 7196354 check-in jdk.tbom file to openjdk repo

Hi Michael, Looks like the list does not reflect the recent changes introduced by the re-organization of the locale data (sun/util/resources). To me, just keeping an eye on the files sounds error prone. Would it be possible to add some automated check, say in "jcheck"? Naoto On 9/10/12 2:2

Re: [8] Review request for 7196354 check-in jdk.tbom file to openjdk repo

Hi Mark and all, I have updated the webrev: http://cr.openjdk.java.net/~mfang/7196354/webrev.01/ It includes the following changes: - removed component division and contact names - removed redundant "target" attributes I am also moving the file from root of source tree to jdk/make/jdk.tbom. S

Re: [8] Review request for 7196354 check-in jdk.tbom file to openjdk repo

Hi Mark, Thanks for the review and feedback. Please see my comments inline below. thanks, -michael On 12年09月06日 01:29 下午, mark.reinh...@oracle.com wrote: 2012/9/5 14:08 -0700, michael.f...@oracle.com: Please help to review the new JDK8 file for the following CR: 7196354 check-in jdk.tbom fi

Re: [8] Review request for 7196354 check-in jdk.tbom file to openjdk repo

2012/9/5 14:08 -0700, michael.f...@oracle.com: > Please help to review the new JDK8 file for the following CR: > 7196354 check-in jdk.tbom file to openjdk repo > > The webrev is located at: > http://cr.openjdk.java.net/~mfang/7196354/webrev.00/ This file needs a more descriptive name, especially

[8] Review request for 7196354 check-in jdk.tbom file to openjdk repo

Hello, Please help to review the new JDK8 file for the following CR: 7196354 check-in jdk.tbom file to openjdk repo The webrev is located at: http://cr.openjdk.java.net/~mfang/7196354/webrev.00/ Build-dev: The file will be pushed to the top level openjdk repository http://hg.openjdk.java.net/j