Re: [8] Code review request: 8000983 and 8003267

2012-12-11 Thread Michael Fang
Hi Masayoshi, I see. Are you able to think of some solution by 1/30 (next jdk8 translation drop)? Without a supported translation format, the l10n files will just sit there without update... thanks, -michael On 2012/12/9 下午 10:36, Masayoshi Okutsu wrote: Hi Michael, I do remember your r

Re: [8] Code review request: 8000983 and 8003267

2012-12-09 Thread Masayoshi Okutsu
Hi Michael, I do remember your request about the translatable format, but I haven't had a chance to address it. The format hasn't changed. Sorry about this. Masayoshi On 12/10/2012 2:23 PM, Michael Fang wrote: Hi Okutsu-san, Do you have a way to provide some sort of converter to make time z

Re: [8] Code review request: 8000983 and 8003267

2012-12-09 Thread Michael Fang
Hi Okutsu-san, Do you have a way to provide some sort of converter to make time zone name translation that can be handled by WPTG translation team? They currently cannot translate the file in existing format (they can translate properties files or basic java resource bundles). thanks, -mich

Re: [8] Code review request: 8000983 and 8003267

2012-12-07 Thread Naoto Sato
Thank you, Okutsu-san. It looks good to me now. Naoto On 12/7/12 8:05 AM, Masayoshi Okutsu wrote: Thank you for your review comments. On 12/7/2012 5:49 AM, Naoto Sato wrote: Here are my comments: - Bundle.java Line 277,297: Do we need two separate iteration loops here? Two iteration loops l

Re: [8] Code review request: 8000983 and 8003267

2012-12-07 Thread Masayoshi Okutsu
Thank you for your review. I thought so too, but I followed the rule for make/* changes. Masayoshi On 12/6/2012 8:36 PM, Erik Joelsson wrote: (resending to all recepients) I don't see any changes to the build except for java classes in the cldrconverter build tool. This shouldn't affect the

Re: [8] Code review request: 8000983 and 8003267

2012-12-07 Thread Masayoshi Okutsu
Thank you for your review comments. On 12/7/2012 5:49 AM, Naoto Sato wrote: Here are my comments: - Bundle.java Line 277,297: Do we need two separate iteration loops here? Two iteration loops look like the same. These loops need to be separated to make inheritance work correctly. Line 303

Re: [8] Code review request: 8000983 and 8003267

2012-12-06 Thread Naoto Sato
Here are my comments: - Bundle.java Line 277,297: Do we need two separate iteration loops here? Two iteration loops look like the same. Line 303: typo "paris" Line 606: typo "Someting" Line 728: Could use foreach here. - CLDRConverter.java Line 388: The FormatData bundle is now "OPEN", wh

Re: [8] Code review request: 8000983 and 8003267

2012-12-06 Thread Erik Joelsson
(resending to all recepients) I don't see any changes to the build except for java classes in the cldrconverter build tool. This shouldn't affect the new build, so it's ok with the build group. /Erik On 2012-12-06 06:06, Masayoshi Okutsu wrote: Resending in order to include build-...@openjdk

[8] Code review request: 8000983 and 8003267

2012-12-05 Thread Masayoshi Okutsu
Resending in order to include build-...@openjdk.java.net and build-in...@openjdk.dev.java.net. Hi, This is a review request for two RFEs. http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000983 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003267 http://cr.openjdk.java.net/~okutsu/8/

[8] Code review request: 8000983 and 8003267

2012-12-02 Thread Masayoshi Okutsu
Hi, This is a review request for two RFEs. http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000983 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003267 http://cr.openjdk.java.net/~okutsu/8/8000983.8003267/webrev.00/ I haven't added generic time zone names to the JRE resources except f