Thanks Brian, Naoto for the review. The below updated patch is pushed to
the repository.
http://cr.openjdk.java.net/~nishjain/8186713/webrev.02/
Regards,
Nishit Jain
On 29-08-2017 04:56, Brian Burkhalter wrote:
Hi Nishit,
I suggest these changes in NumberFormat.java:
184:delete the line
186:
Hi Nishit,
I suggest these changes in NumberFormat.java:
184:delete the line
186:s/{@code NumberFormat}/The default implementation/
187-188:s/By default, it uses/It uses/
With these changes I am fine with the patch and no need to send an updated
webrev unless you
Hi Brian,
> L178-195: Is a list necessary here?
The list approach is used to clearly mention that these two points are
under "Implementation Requirements". If it does not look good, another
way could be to use @implSpec tag for individual points, separated by
. Please check if this is fine.
A few minor comments:
L178-195: Is a list necessary here?
L186: I don’t think “Rounding: " is necessary.
L187: s/the numbers/numbers/
L188: s/uses/uses the/
L191: s/its/the/
Thanks,
Brian
On Aug 24, 2017, at 12:06 AM, Nishit Jain wrote:
> Webrev:http://cr.openjdk.java.net/~nishjain/818671
Looks good.
Naoto
On 8/24/17 12:06 AM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8186713
Bug: https://bugs.openjdk.java.net/browse/JDK-8186713
Webrev: http://cr.openjdk.java.net/~nishjain/8186713/webrev.00/
CSR: https://bugs.openjdk.java.net/browse/JDK-8185777
Fix: Updated the spe
Hi,
Please review the fix for JDK-8186713
Bug: https://bugs.openjdk.java.net/browse/JDK-8186713
Webrev: http://cr.openjdk.java.net/~nishjain/8186713/webrev.00/
CSR: https://bugs.openjdk.java.net/browse/JDK-8185777
Fix: Updated the specification of NumberFormat about the default
rounding mode u
