Re: < i18n dev> Request for review: Crash on XIM server restart

2010-09-27 Thread Omair Majid
Hi, On 09/23/2010 02:20 PM, Naoto Sato wrote: OK, I created 6986968 for this. It will show up in the external bug database soon. Thanks! I have pushed the changeset: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/bbadb9484f53 Cheers, Omair

Re: < i18n dev> Request for review: Crash on XIM server restart

2010-09-23 Thread Naoto Sato
OK, I created 6986968 for this. It will show up in the external bug database soon. Naoto (9/22/10 10:55 PM), Martin Buchholz wrote: On Wed, Sep 22, 2010 at 14:53, Naoto Sato wrote: Also, is it possible to get a bug id for this? I am not familiar with this process, but according to this pa

Re: < i18n dev> Request for review: Crash on XIM server restart

2010-09-22 Thread Martin Buchholz
On Wed, Sep 22, 2010 at 14:53, Naoto Sato wrote: >> Also, is it possible to get a bug id for this? > > I am not familiar with this process, but according to this page > (http://openjdk.java.net/contribute/), you can create a new bug report in > the OpenJDK Bugzilla. An Oracle sponsor still needs

Re: < i18n dev> Request for review: Crash on XIM server restart

2010-09-22 Thread Naoto Sato
(9/22/10 7:09 AM), Omair Majid wrote: Hi, On 09/21/2010 01:40 PM, Naoto Sato wrote: Looks good to me. Naoto Thanks for the review. Should I use the swing forest to push this change (which I believe is what the i18n group uses) or the awt forest? Swing forest is just fine. Also, is it po

Re: < i18n dev> Request for review: Crash on XIM server restart

2010-09-22 Thread Omair Majid
Hi, On 09/21/2010 01:40 PM, Naoto Sato wrote: Looks good to me. Naoto Thanks for the review. Should I use the swing forest to push this change (which I believe is what the i18n group uses) or the awt forest? Also, is it possible to get a bug id for this? Thanks, Omair (9/20/10 7:33 AM)

Re: < i18n dev> Request for review: Crash on XIM server restart

2010-09-21 Thread Naoto Sato
Looks good to me. Naoto (9/20/10 7:33 AM), Omair Majid wrote: Hi, Naoto Sato writes: Thank you for catching the error. I think your fix is fine but would like some comments noting that the extra call to getX11InputMethodData() in DestroyXIMCallback is merely to free up the pX11IMData, other

Re: < i18n dev> Request for review: Crash on XIM server restart

2010-09-20 Thread Omair Majid
Hi, Naoto Sato writes: > > Thank you for catching the error. I think your fix is fine but would > like some comments noting that the extra call to getX11InputMethodData() > in DestroyXIMCallback is merely to free up the pX11IMData, otherwise, > the call is kind of cryptic. > Thanks for revi