Re: RFR: 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

2022-03-15 Thread Zhengyu Gu
On Thu, 10 Mar 2022 19:46:28 GMT, Naoto Sato wrote: >> Please review this small patch that fixes early `CHECK_NULL_RETURN` results >> not releasing native `jchar` array returned by `GetStringChars()`. > > LGTM. Thanks, @naotoj @AlanBateman - PR: https://git.openjdk.java.net/jdk/pu

Integrated: 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

2022-03-15 Thread Zhengyu Gu
On Thu, 10 Mar 2022 18:40:13 GMT, Zhengyu Gu wrote: > Please review this small patch that fixes early `CHECK_NULL_RETURN` results > not releasing native `jchar` array returned by `GetStringChars()`. This pull request has now been integrated. Changeset: 2cddf3f5 Author:Zhengyu G

Re: RFR: 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

2022-03-15 Thread Zhengyu Gu
On Thu, 10 Mar 2022 18:40:13 GMT, Zhengyu Gu wrote: > Please review this small patch that fixes early `CHECK_NULL_RETURN` results > not releasing native `jchar` array returned by `GetStringChars()`. Friendly ping. May I have a second review, please! - PR:

RFR: 8282887: Potential memory leak in sun.util.locale.provider.HostLocalProviderAdapterImpl.getNumberPattern() on Windows

2022-03-10 Thread Zhengyu Gu
Please review this small patch that fixes early `CHECK_NULL_RETURN` results not releasing native `jchar` array returned by `GetStringChars()`. - Commit messages: - 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Window

Re: RFR: 8282897: Fix call parameter to GetStringChars() in HostLocaleProviderAdapter_md.c

2022-03-10 Thread Zhengyu Gu
On Thu, 10 Mar 2022 17:25:55 GMT, Naoto Sato wrote: > LGTM. Thanks for the fix! Thanks for the review. - PR: https://git.openjdk.java.net/jdk/pull/7775

Integrated: 8282897: Fix call parameter to GetStringChars() in HostLocaleProviderAdapter_md.c

2022-03-10 Thread Zhengyu Gu
On Thu, 10 Mar 2022 13:33:05 GMT, Zhengyu Gu wrote: > Please review this trivial patch to correct last parameter of > `GetStringChars()` call, which should be a `jboolean*`, instead of `jboolean` This pull request has now been integrated. Changeset: 879b6445 Author:Zhengyu G

Re: RFR: 8282897: Fix call parameter to GetStringChars() in HostLocaleProviderAdapter_md.c

2022-03-10 Thread Zhengyu Gu
On Thu, 10 Mar 2022 15:28:15 GMT, Aleksey Shipilev wrote: > Looks fine to me. Thanks, @shipilev - PR: https://git.openjdk.java.net/jdk/pull/7775

RFR: 8282897: Fix call parameter to GetStringChars() in HostLocaleProviderAdapter_md.c

2022-03-10 Thread Zhengyu Gu
Please review this trivial patch to correct last parameter of `GetStringChars()` call, which should be a `jboolean*`, instead of `jboolean` - Commit messages: - 8282897: Fix call parameter to GetStringChars() in HostLocaleProviderAdapter_md.c Changes: https://git.openjdk.java.net