On Tue, 19 Apr 2022 16:50:12 GMT, Magnus Ihse Bursie wrote:
>> I ran `codespell` on the `src/java.base` directory, and accepted those
>> changes where it indeed discovered real typos.
>>
>> (Due to false positives this can unfortunately not be run automatically)
>>
>> The majority of fixes ar
On Thu, 14 Apr 2022 20:16:38 GMT, Sean Mullan wrote:
>>> Are the changes necessary for this part?
>>
>> @seanjmullan no, they are just performance refinement.
>>
>> If you really that wanna 100% sync ,
>>
>> I can use the old 1.8 api to migrate tha
On Thu, 14 Apr 2022 20:16:21 GMT, Bradford Wetmore wrote:
>> I ran `codespell` on the `src/java.base` directory, and accepted those
>> changes where it indeed discovered real typos.
>>
>> (Due to false positives this can unfortunately not be run automatically)
>>
>> The majority of fixes are
On Thu, 14 Apr 2022 20:11:37 GMT, XenoAmess wrote:
> > Are the changes necessary for this part?
>
> @seanjmullan no, they are just performance refinement.
>
> If you really that wanna 100% sync ,
>
> I can use the old 1.8 api to migrate that part, and make a mirror pr to that
> part of https:
On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add `@LastModified: Apr 2022` to DocumentCache
Right, we generally try to
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream
On Thu, 9 Sep 2021 20:12:47 GMT, Andrey Turbanov
wrote:
> Redundant castings make code harder to read.
> Found them by IntelliJ IDEA.
> I tried to select only casts which are definitely safe to remove. Also didn't
> touch primitive types casts.
The security related files look fine.
--
On Fri, 21 May 2021 15:27:39 GMT, Daniel Fuchs wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixing awt/datatransfer/DataFlavor/DataFlavorRemoteTest.java
>
> src/java.base/share/classes/java/lang/SecurityManager.j
On Tue, 18 May 2021 21:44:43 GMT, Weijun Wang wrote:
>> Please review the test changes for [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> With JEP 411 and the default value of `-Djava.security.manager` becoming
>> `disallow`, tests calling `System.setSecurityManager()` need
>> `-Djav
On Tue, 18 May 2021 15:19:21 GMT, Alan Bateman wrote:
>> It includes both:
>> 
>
> Thanks for checking, I assumed that was the case so wondering if it
On Tue, 18 May 2021 06:31:06 GMT, Alan Bateman wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e3
Looks good. Are there any regression tests for this component that run
with a SecurityManager? If not, it would be useful to add some to ensure
that the proper permissions are being granted to this module.
--Sean
On 11/14/16 2:27 AM, Rachna Goel wrote:
sorry, correction to typo
As jdk.locale
Looks fine. Don't forget to add a noreg-doc label to the bug.
--Sean
On 05/06/2015 12:50 PM, Naoto Sato wrote:
Hi Sean,
Can you please review the change to RuntimePermission's class document?
This is a follow-on fix to the prior fix to 8075545.
Bug: https://bugs.openjdk.java.net/browse/JDK-80
13 matches
Mail list logo
