RFR: 8283608: Refactor 2d, beans classes javadoc to use @throws instead of @exception

2022-03-23 Thread Prasanta Sadhukhan
Prevailing JDK coding practices use "@throws" rather than "@exception". Need to refactor remaining 2d, beans,sound classes to use @throws - Commit messages: - Fix - Fix Changes: https://git.openjdk.java.net/jdk/pull/7937/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=

RFR: 8282602: Refactor java/awt classes javadoc to use @throws instead of @exception

2022-03-03 Thread Prasanta Sadhukhan
Prevailing JDK coding practices use "@throws" rather than "@exception". Refactor existing java/awt classes javadoc to use @throws - Commit messages: - Fix - Fix Changes: https://git.openjdk.java.net/jdk/pull/7675/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7675&ran

Integrated: 8278254: Cleanup doclint warnings in java.desktop module

2022-02-02 Thread Prasanta Sadhukhan
On Mon, 10 Jan 2022 05:25:51 GMT, Prasanta Sadhukhan wrote: > The changes done under JDK-8278175 suppress on a per-file basis various > missing comments that would otherwise trigger doclint warnings. Fixed them so > as to remove the doclint:missing warnings. This pull request has

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v7]

2022-02-01 Thread Prasanta Sadhukhan
> The changes done under JDK-8278175 suppress on a per-file basis various > missing comments that would otherwise trigger doclint warnings. Fixed them so > as to remove the doclint:missing warnings. Prasanta Sadhukhan has updated the pull request incrementally with one additional com

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v5]

2022-01-30 Thread Prasanta Sadhukhan
On Fri, 28 Jan 2022 19:29:14 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review comment > > src/java.desktop/share/classes/java/awt/Compon

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v6]

2022-01-30 Thread Prasanta Sadhukhan
> The changes done under JDK-8278175 suppress on a per-file basis various > missing comments that would otherwise trigger doclint warnings. Fixed them so > as to remove the doclint:missing warnings. Prasanta Sadhukhan has updated the pull request incrementally with one additional com

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v5]

2022-01-26 Thread Prasanta Sadhukhan
On Mon, 24 Jan 2022 06:03:42 GMT, Prasanta Sadhukhan wrote: >> The changes done under JDK-8278175 suppress on a per-file basis various >> missing comments that would otherwise trigger doclint warnings. Fixed them >> so as to remove the doclint:missing warnings. > >

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v4]

2022-01-24 Thread Prasanta Sadhukhan
On Mon, 24 Jan 2022 10:51:00 GMT, Alexey Ivanov wrote: >> It is already mentioned in getSystemDisplayName, getSystemTypeDescription, >> getSystemIcon, isRoot. Anyways, I have removed the linkage for the new >> addition as it will not be able to resolve. > > If `ShellFolder` remains mentioned, I

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v5]

2022-01-23 Thread Prasanta Sadhukhan
> The changes done under JDK-8278175 suppress on a per-file basis various > missing comments that would otherwise trigger doclint warnings. Fixed them so > as to remove the doclint:missing warnings. Prasanta Sadhukhan has updated the pull request incrementally with one additional com

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v4]

2022-01-23 Thread Prasanta Sadhukhan
On Fri, 21 Jan 2022 07:43:17 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix > > src/java.desktop/share/classes/javax/swing/filechooser/FileSystemVi

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v4]

2022-01-19 Thread Prasanta Sadhukhan
> The changes done under JDK-8278175 suppress on a per-file basis various > missing comments that would otherwise trigger doclint warnings. Fixed them so > as to remove the doclint:missing warnings. Prasanta Sadhukhan has updated the pull request incrementally with one additional com

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v3]

2022-01-19 Thread Prasanta Sadhukhan
> The changes done under JDK-8278175 suppress on a per-file basis various > missing comments that would otherwise trigger doclint warnings. Fixed them so > as to remove the doclint:missing warnings. Prasanta Sadhukhan has updated the pull request incrementally with one additional com

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v2]

2022-01-16 Thread Prasanta Sadhukhan
On Tue, 11 Jan 2022 05:19:56 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review fix > > src/java.desktop/share/classes/java/awt/BufferCapabilities.

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v2]

2022-01-16 Thread Prasanta Sadhukhan
> The changes done under JDK-8278175 suppress on a per-file basis various > missing comments that would otherwise trigger doclint warnings. Fixed them so > as to remove the doclint:missing warnings. Prasanta Sadhukhan has updated the pull request incrementally with one additional com

RFR: 8278254: Cleanup doclint warnings in java.desktop module

2022-01-09 Thread Prasanta Sadhukhan
The changes done under JDK-8278175 suppress on a per-file basis various missing comments that would otherwise trigger doclint warnings. Fixed them so as to remove the doclint:missing warnings. - Commit messages: - Fix - 8278254: Cleanup doclint warnings in java.desktop module Cha

Re: RFR: 8259522: Apply java.io.Serial annotations in java.desktop [v2]

2021-01-12 Thread Prasanta Sadhukhan
On Tue, 12 Jan 2021 20:42:18 GMT, Sergey Bylokhov wrote: >> Please review the application of @java.io.Serial annotation (JDK-8202385) to >> types in the desktop module to enable stricter compile-time checking of >> serialization-related declarations. >> >> This annotation can be applied to the

Re: RFR: 8259522: Apply java.io.Serial annotations in java.desktop [v2]

2021-01-12 Thread Prasanta Sadhukhan
On Tue, 12 Jan 2021 20:42:18 GMT, Sergey Bylokhov wrote: >> Please review the application of @java.io.Serial annotation (JDK-8202385) to >> types in the desktop module to enable stricter compile-time checking of >> serialization-related declarations. >> >> This annotation can be applied to the

Re: RFR: 8253322 : Update the specification in the newly added constructors

2020-09-23 Thread Prasanta Sadhukhan
On Wed, 23 Sep 2020 07:03:59 GMT, Sergey Bylokhov wrote: > Looks like different people use a different style for the new constructors, > it will be good to unify them. > I have started from https://bugs.openjdk.java.net/browse/JDK-8252721 > See > https://bugs.openjdk.java.net/browse/JDK-8252908?