Thanks Naoto,
Updated: http://cr.openjdk.java.net/~nishjain/8217254_8217721/webrev.01/
Regards,
Nishit Jain
On 06-03-2019 23:24, naoto.s...@oracle.com wrote:
Hi Nishit,
Just one comment on j.t.CompactNumberFormat.java. At line 425, Null
check can be done at the top of the method, as a
() method was not
compliant with the specification
Fix: Updated the constructor and format method to throw exception as per
the specification
Regards,
Nishit Jain
x27;a' character and hence resolved with
am/pm strings. This is based on the LDML specification given for 'B'
character in which it falls back to 'a' character if it is not supported
by any locale.
Regards,
Nishit Jain
Hi Naoto,
Thanks for the explanation. Change looks fine to me.
Regards,
Nishit Jain
On 19-02-2019 22:51, Naoto Sato wrote:
Hi Nishit,
The reason is that "US" is the only required locale in the JDK (cf.
Locale.getAvailableLocales(). In fact, initially I supplied "001" w
ot;? Can't we just return "1" instead of
setting the region to "US"?
Regards,
Nishit Jain
On 16-02-2019 04:25, Naoto Sato wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8218960
The proposed changeset is located at:
sed only to test the overflow condition in Decoder.decode() which
is no longer there.
Regards,
Nishit Jain
Hi Naoto,
Look good to me.
Regards,
Nishit Jain
On 26-01-2019 01:29, naoto.s...@oracle.com wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8217609
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8217609/webrev.00
Looks Good.
Regards,
Nishit Jain
On 17-01-2019 22:07, Naoto Sato wrote:
Hi Nishit,
Thanks. Updated:
http://cr.openjdk.java.net/~naoto/8216969/webrev.01/
Naoto
On 1/17/19 2:57 AM, Nishit Jain wrote:
Hi Naoto,
Looks good to me. Just a small suggestion.
- To improve readability, can we
Hi Naoto,
Looks good to me. Just a small suggestion.
- To improve readability, can we declare "standalone mask" (0x8000) as a
static field and use that at all the places?
Regards,
Nishit Jain
On 17-01-2019 05:50, naoto.s...@oracle.com wrote:
Hi,
Please review the fix to the follo
is an unrelated change in
encodeToString(byte[]) where a string instance is created using
JavaLangAccess.newStringNoRepl(byte[], ISO_8859_1)instead of string
constructor, to save memory.
Regards,
Nishit Jain
Changes looks fine to me.
Regards,
Nishit Jain
On 03-01-2019 22:26, Naoto Sato wrote:
Hello,
Please review the fix to the following issue (and its approved CSR):
https://bugs.openjdk.java.net/browse/JDK-8215303
https://bugs.openjdk.java.net/browse/JDK-8215305
The proposed changeset is
://bugs.openjdk.java.net/browse/JDK-8214935
Webrev: http://cr.openjdk.java.net/~nishjain/8214935/webrev.00/
Regards,
Nishit Jain
Hi,
Please review the fix for 8213294, which upgrades the IANA LSR data to
the latest available version.
Bug: https://bugs.openjdk.java.net/browse/JDK-8213294
Webrev: http://cr.openjdk.java.net/~nishjain/8213294/webrev.00
Regards,
Nishit Jain
Thanks Naoto,
Updated.
http://cr.openjdk.java.net/~nishjain/8177552/webrevs/webrev.04/
Regards,
Nishit Jain
On 27-11-2018 20:55, naoto.s...@oracle.com wrote:
Hi Nishit,
On 11/26/18 11:11 PM, Nishit Jain wrote:
Hi Naoto,
On 26-11-2018 21:01, naoto.s...@oracle.com wrote:
Hi Nishit,
On 11
Hi Naoto,
On 26-11-2018 21:01, naoto.s...@oracle.com wrote:
Hi Nishit,
On 11/26/18 12:41 AM, Nishit Jain wrote:
Hi Naoto,
To add to my previous mail comment, the DecimalFormat spec also says
that
/*"DecimalFormat can be instructed to format and parse scientific
notation only
I am aware of, unless you are pointing to the issue like
JDK-8211161, which we know is not an issue.
Regards,
Nishit Jain
On 23-11-2018 15:55, Nishit Jain wrote:
Hi Naoto,
> I think DecimalFormat and CNF should behave the same, ie. 'E' should
be treated as the exponent without a quot
ential numbers are needed it should be done by
DecimalFormat scientific instance *not *with the general number
instance.So, I don't think that we should allow parsing of exponential
numbers.Comments welcome.
Regards,
Nishit Jain
On 22-11-2018 02:02, naoto.s...@oracle.com wrote:
Hi Nishi
duplication.
- Also updated it with other changes as suggested in the comments
Regards,
Nishit Jain
On 20-11-2018 00:33, naoto.s...@oracle.com wrote:
Hi Nishit,
On 11/18/18 10:29 PM, Nishit Jain wrote:
Hi Naoto,
Please check my comments inline.
On 17-11-2018 04:52, naoto.s...@oracle.com wrote:
Hi
before cast. Otherwise
ClassCastException may be thrown.
The type is checked in the superclass equals method getClass() !=
obj.getClass(), so I think there is no need to check the type here.
Regards,
Nishit Jain
Naoto
On 11/16/18 9:54 AM, Nishit Jain wrote:
Hi,
Please review this non trivia
dk.java.net/browse/JDK-8188147
Request to please help review the the change.
Regards,
Nishit Jain
+1
On 24-09-2018 23:04, Naoto Sato wrote:
Looks good to me.
Naoto
On 9/24/18 5:57 AM, Dora Zhou wrote:
Hello,
Please help review the fix for migrating GS-auto Locale matching
tests to JDK repository. Please refer to the bug description for
details.
Bug: https://bugs.openjdk.java.net/brow
access, but they
are not getting used elsewhere in the package. Removed them from
ChoiceFormat class.
Regards,
Nishit Jain
x27;s nextDouble(double),
previousDouble(double), nextDouble(double, boolean) APIs implementation
to delegate the execution to the equivalent Math APIs
Regards,
Nishit Jain
as 8-bit.
Fix: The handling of long_length (> 254) for non-ASCII unicode
characters is missing in the compilation phase of the format pattern,
added that in the fix.
Regards,
Nishit Jain
be updated,
it automatically cross checks the updated lsr data.
Regards,
Nishit Jain
Hi,
Please review the fix for JDK-8203872.
Bug: https://bugs.openjdk.java.net/browse/JDK-8203872
Webrev: http://cr.openjdk.java.net/~nishjain/8203872/webrev.01/
Fix: Updated the LSR data to the version 2017-08-15
Regards,
Nishit Jain
ping separator position identification is skipped.
8199672: Check if the instance returned is DecimalFormat; else, use
DecimalFormat constructor to obtain the instance.
Regards,
Nishit Jain
Thanks Naoto,
Please check the updated webrev
http://cr.openjdk.java.net/~nishjain/8060094/webrev.04/
Edits made: In FormatLocale.java, clarified the exception messages about
the locale used and removed an unused import.
Regards,
Nishit Jain
On 23-02-2018 00:56, Naoto Sato wrote:
Hi Nishit
when specified during instance creation or during format() call.
The default locale was getting used irrespective of whether a Locale is
specified in the API.
Fix: Modified the APIs to use the locale specified.
Regards,
Nishit Jain
nit. These are
ignored as inconsistent entries. Also, If there is any ISO 4217 currency
data with same currency code as the currency entry given in the
properties file, then the existing Currency data should be updated with
the given currency values.
Regards,
Nishit Jain
not,
then use the DecimalFormat constructor way to create its object,
where SPI provider implementation is ignored.
Regards,
Nishit Jain
Thanks Roger,
Updated the webrevto add the new test case in MessageRegression.java
http://cr.openjdk.java.net/~nishjain/8187551/webrev.03/
Regards,
Nishit Jain
On 01-12-2017 20:40, Roger Riggs wrote:
Hi Nishit,
Please add the new test to
test/jdk/java/text/Format/MessageFormat
for filing the issue and suggesting the fix.
Regards,
Nishit Jain
per javadoc or the javadoc will be
changed.
> Please change the issue summary (on both the CSR and the issue) to
reflect the true cause.
Done
Regards,
Nishit Jain
On 29-11-2017 20:35, Roger Riggs wrote:
Hi Nishit,
The webrev and updates to the javadoc look fine.
However, the summary of the
eparate issue.
I would like to bring one point to notice that, I have not added all the
new tags (which are added in this version) in the test case, just few of
them are added to test that LocaleEquivalentMaps are properly updated.
Hope that is fine.
Regards,
Nishit Jain
On 22-11-2017 04:47,
APIs specification.
Regards,
Nishit Jain
Hi,
Please review the fix for JDK-8191404
Bug: https://bugs.openjdk.java.net/browse/JDK-8191404
Webrev: http://cr.openjdk.java.net/~nishjain/8191404/webrev.00/
Fix: Updated the LSR data with the version: 2017-08-15
Regards,
Nishit Jain
Looks good to me. I am not a reviewer, though.
Regards,
Nishit Jain
On 31-08-2017 04:25, Naoto Sato wrote:
Hi,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8180469
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8180469
Thanks Brian, Naoto for the review. The below updated patch is pushed to
the repository.
http://cr.openjdk.java.net/~nishjain/8186713/webrev.02/
Regards,
Nishit Jain
On 29-08-2017 04:56, Brian Burkhalter wrote:
Hi Nishit,
I suggest these changes in NumberFormat.java:
184:delete the line
186
this is fine.
Also updated the webrev with other suggested changes.
http://cr.openjdk.java.net/~nishjain/8186713/webrev.01/
Regards,
Nishit Jain
On 25-08-2017 00:55, Brian Burkhalter wrote:
A few minor comments:
L178-195: Is a list necessary here?
L186: I don’t think “Rounding: " is neces
used while formatting the numbers. Also, in the
specification of java.util.Formatter, changed the reference of the
deprecated BigDecimal.ROUND_HALF_UP,with java.math.RoundingMode.HALF_UP.
Regards,
Nishit Jain
Hi,
Please review the fix for JDK-6609718
Bug: https://bugs.openjdk.java.net/browse/JDK-6609718
Webrev: http://cr.openjdk.java.net/~nishjain/6609718/webrev.01/
Fix: source updated to provide information about the cause of exception.
Regards,
Nishit Jain
Thanks Roger,
Made the suggested changes related to hardcoded copyright year. Please
check the updated webrev
http://cr.openjdk.java.net/~nishjain/8177472/webrev.06/
Regards,
Nishit Jain
On 25-07-2017 22:55, Roger Riggs wrote:
Hi,
I was focused mostly on *not *hardcoding the copyright text
rds,
Nishit Jain
On 25-07-2017 21:28, Roger Riggs wrote:
Hi Nishit,
Can the hardcoded copyright be made more automatic?
I see the make/src/classes/build/tools/cldrconverter has functions to
create/convert copyrights.
Can that be leveraged to generate the needed copyright and reduce some
potent
A gentle reminder! Requesting for a build review
Regards,
Nishit Jain
On 20-07-2017 23:36, Naoto Sato wrote:
Looks good to me.
Naoto
On 7/19/17 10:33 PM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8177472
Bug: https://bugs.openjdk.java.net/browse/JDK-8177472
Webrev: http
EquivMapsGenerator.java (if required) for the generated maps file.
Regards,
Nishit Jain
list of output tags.
Regards,
Nishit Jain
the java.base module. This is my understanding about the change.
Regards,
Nishit Jain
On 14-06-2017 12:53, Alan Bateman wrote:
On 09/06/2017 07:59, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8176583
Bug: https://bugs.openjdk.java.net/browse/JDK-8176583
Webrev: http
Thanks Naoto,
Please check the updated webrev
http://cr.openjdk.java.net/~nishjain/8176583/webrev.02/
Changes:
- merged the try blocks in Currency.java
- replaced the try block in CheckDataVersion.java with try-with-resource
and a small indentation change at line 82.
Regards,
Nishit Jain
On
Hi,
Please review the fix for JDK-8176583
Bug: https://bugs.openjdk.java.net/browse/JDK-8176583
Webrev: http://cr.openjdk.java.net/~nishjain/8176583/webrev.01/
Fix: Relocated currency.data from java.base module
(/java.base/java/util/currency.data) to /lib directory
Regards,
Nishit Jain
characters e.g. digits, zeroDigit,
groupingSeparator, decimalSeparator, exponent in a negative
sub-patternand consider only prefix and suffix part.
Regards,
Nishit Jain
nt in the @implSpec tag
Regards,
Nishit Jain
behave
differently in second invocation. Changed String.replace* methods with
String.replace() at places where it is dealing with a literal string not
with a regular expression.
Regards,
Nishit Jain
array buffer
to handle the format calls. Changes are made to reset the FastPathData
in each subsequent format calls.
Regards,
Nishit Jain
Hi Naoto,
Thanks for the review.
Yes, you are correct, I somehow missed to mention the correct reason for
that.
Regards,
Nishit Jain
On 16-09-2016 22:30, Naoto Sato wrote:
Looks good.
BTW, I believe making it "final" means to make sure every threads are
guaranteed to see the
variable is
made volatile in ListResourceBundle to make sure that multiple threads
read the value from main memory.
Regards,
Nishit Jain
the spec
of weekdays methods.
Regards,
Nishit Jain
. the range
specified with quality weight 0 (q=0). The mechanism to handle q=0 was
not there in the previous implementation.
Regards,
Nishit Jain
.
Regards,
Nishit Jain
. A typo
is corrected in the java.text.DateFormatSymbols.java
Regards,
Nishit Jain
range and language tag must always be "a-z" "0-9" or '-'
Regards,
Nishit Jain
Hi,
Please review the fix for JDK-8135061
Bug: https://bugs.openjdk.java.net/browse/JDK-8135061
Webrev: http://cr.openjdk.java.net/~nishjain/8135061/webrev.01/
Fix : Added a check on the lastIndexOf "-" before using substring for
truncating the extension key
Regards,
Nishit Jain
guage-subtag-registry";
and the related java files
Regards,
Nishit Jain
Hi,
Please review the fix for JDK-8047780
Bug: https://bugs.openjdk.java.net/browse/JDK-8047780
Webrev: http://cr.openjdk.java.net/~nishjain/8047780/webrev.01/
Fix: Added in the api spec that the IllegalArgumentException can be
thrown if the given "range" is ill-formed
Regards,
Nishit Jain
.
Regards,
Nishit Jain
Hi,
Please review the fix for JDK-8158025.
Webrev : http://cr.openjdk.java.net/~nishjain/8158025/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8158025
Fix: corrected a small typo in Locale.java.
Regards,
Nishit Jain
Hello All,
Please review the updated webrev synced with the latest repository.
http://cr.openjdk.java.net/~nishjain/7102969_and_8157138/webrev.08/
Regards,
Nishit Jain
On 5/18/2016 3:42 PM, Nishit Jain wrote:
Hello All,
Please review the fix for JDK-7102969 and JDK-8157138 (Fixing multiple
Currency.getAvailableCurrencies() to return the special case currency
entries
Regards,
Nishit Jain
Hello All,
Please review the fix for JDK-8149452
Bug: https://bugs.openjdk.java.net/browse/JDK-8149452
Webrev: http://cr.openjdk.java.net/~nishjain/8149452/webrev.01/
Fix: Made some changes to the CLDRConverter.java to handle the condition
of missing timezone name in CLDR
Regards,
Nishit
Hello All,
Please review the fix for JDK-8154295.
http://cr.openjdk.java.net/~nishjain/8154295/webrev.07/
Changes made to the webrev.04: Added a simple test case and some comments
Regards,
Nishit Jain
On 5/2/2016 11:27 AM, Nishit Jain wrote:
Hello All,
Please review the following fix for
ys
return a 3 digit numeric code as a String
Regards,
Nishit Jain
sensitive classes e.g. Currency, Calendar, Collator
etc.) to OpenJDK or just a set of translations for a language? An
example on that would be very helpful.
Regards,
Nishit Jain
On 4/9/2016 9:30 AM, USHAKOV, Sergey wrote:
Hi,
Oracle JDK and OpenJDK offer internationalized resources for quite a
Hi,
Thanks for pointing that out.
Please review the updated webrev at the below mentioned link
http://cr.openjdk.java.net/~peytoia/Nishit/8150324/webrev.02/
Regards,
Nishit Jain
On 4/11/2016 4:46 PM, Yuka Kamiya wrote:
Hi Nishit,
Can you please replace
"jdk/src/share/classes/java
of the system.
Regards,
Nishit Jain
Hello All,
Please review the following fix in "windows.fontconfig.properties"
Bug: https://bugs.openjdk.java.net/browse/JDK-8031992
Webrev: http://cr.openjdk.java.net/~rgoel/Nishit/8031992/webrev.01/
Fix: Added Windows' Kannada font i.e. "Tunga" definition to the fo
20BD from exclusion range
Regards,
Nishit Jain
): Rephrasing of text in
the /getDefaultFractionDigits()/ method description.
Regards,
Nishit Jain
On 2/15/2016 5:38 PM, Nishit Jain wrote:
Hello All,
Please review the following fix in "/Currency.java/".
Bug: https://bugs.openjdk.java.net/browse/JDK-8074411
Webrev: http://cr.open
" and "default number of fraction
digits" is added in the specification. A suggestion to use BigDecimal
class while working with Currency or monetary values is also added.
Regards,
Nishit Jain
78 matches
Mail list logo
