Re: RFR: 8279918: Fix various doc typos [v2]

2022-01-14 Thread Jan Lahoda
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote: >> - Most of the typos are of a trivial kind: missing whitespace. >> - If any of the typos should be fixed in the upstream projects instead, >> please say so; I will drop those typos from the patch. >> - As I understand it, ` ` in ImageInputSt

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows

2021-10-04 Thread Jan Lahoda
On Mon, 4 Oct 2021 08:47:26 GMT, Ichiroh Takiguchi wrote: >> The encoding used in `Log.java` should first check whether it is run within >> console or not. If `System.console()` returns the console, its `.charset()` >> should be used instead of `native.encoding` value. >> As to the jshell issu

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows

2021-10-01 Thread Jan Lahoda
On Fri, 1 Oct 2021 11:56:03 GMT, Jan Lahoda wrote: > Regarding javac, the patch to `Log.java` seems to be in a reasonable > direction: the write is to the physical `System.out/err` which should be > done(?) using the native encoding. The order of the changed lines should be > fi

Re: RFR: 8274544: Langtools command's usage were grabled on Japanese Windows

2021-10-01 Thread Jan Lahoda
On Thu, 30 Sep 2021 09:36:34 GMT, Ichiroh Takiguchi wrote: > JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. > After JDK18-b13, javac and some other langtool command's usage were garbled > on Japanese Windows. > These commands use PrintWriter instead of standard out/err with PrintStream. R