Re: RFR: 8273111: Default timezone should return zone ID if /etc/localtime is valid but not canonicalization on linux [v5]

2021-10-19 Thread Hamlin Li
On Tue, 19 Oct 2021 04:08:12 GMT, Wu Yan wrote: >> Hi, >> Please help me review the change to enhance getting time zone ID from >> /etc/localtime on linux. >> >> We use `realpath` instead of `readlink` to obtain the link name of >> /etc/localtime, because `readlink` can only read the value of

Re: RFR: 8273111: Default timezone should return zone ID if /etc/localtime is valid but not canonicalization on linux [v4]

2021-10-15 Thread Hamlin Li
On Thu, 14 Oct 2021 02:08:45 GMT, Wu Yan wrote: >> Hi, >> Please help me review the change to enhance getting time zone ID from >> /etc/localtime on linux. >> >> We use `realpath` instead of `readlink` to obtain the link name of >> /etc/localtime, because `readlink` can only read the value of

[10] RFR: 8195478: sun/text/resources/LocaleDataTest.java fails with java.lang.Exception

2018-03-08 Thread Hamlin Li
Would you please review the following patch? bug: https://bugs.openjdk.java.net/browse/JDK-8195478 webrev as below I have tested it locally. Thank you -Hamlin diff -r 19effb7970bc test/jdk/sun/text/resources/LocaleData

[10] RFR: 8195478: sun/text/resources/LocaleDataTest.java fails with java.lang.Exception

2018-03-08 Thread Hamlin Li
Would you please review the following patch? bug: https://bugs.openjdk.java.net/browse/JDK-8195478 webrev as below I have tested it locally. Thank you -Hamlin diff -r 19effb7970bc test/jdk/sun/text/resources/LocaleData

Re: [10] RFR: 8195478: sun/text/resources/LocaleDataTest.java fails with java.lang.Exception

2018-03-08 Thread Hamlin Li
On 1/17/2018 1:37 PM, Hamlin Li wrote: Would you please review the following patch? bug: https://bugs.openjdk.java.net/browse/JDK-8195478 webrev as below I have tested it locally. Thank you -Hamlin diff -r 19effb7970b

Re: [10] RFR: 8195478: sun/text/resources/LocaleDataTest.java fails with java.lang.Exception

2018-01-17 Thread Hamlin Li
, please add @bug to LocaleDataTest.java. No further review is needed. Naoto On 1/17/18 12:50 AM, Hamlin Li wrote: Hi Rachna, I'm not sure, but I think in this case (it's a test bug) @bug 8195478 should not be added. Thank you -Hamlin On 17/01/2018 4:45 PM, Rachna Goel wrote: