Integrated: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-22 Thread Dmitry Markov
On Tue, 19 Jan 2021 11:10:35 GMT, Dmitry Markov wrote: > Problem description: > The IME behaviour has changed starting from recent Windows 10 builds. In > particular if the complex characters (Japanese, Chinese, etc.) are entered to > some component and the focus is transferre

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 [v2]

2021-01-21 Thread Dmitry Markov
On Thu, 21 Jan 2021 21:34:25 GMT, Alexey Ivanov wrote: >> Dmitry Markov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use endComposition() instead of endCompositionNative() > > Marked as reviewe

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-21 Thread Dmitry Markov
On Thu, 21 Jan 2021 19:25:16 GMT, Alexey Ivanov wrote: > I admit I am even more confused now. To me, the description in the comment > above is nearly the same as in [JBS > comment](https://bugs.openjdk.java.net/browse/JDK-8258805?focusedCommentId=14391025&page=com.atlassian.jira.plugin.system.i

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-21 Thread Dmitry Markov
On Thu, 21 Jan 2021 14:18:43 GMT, Alexey Ivanov wrote: > > Now we will commit the composition string if there is an active client. > > That changes eliminates the issue described in JDK-8258805. Also the > > behaviour of AWTTextTest1 is the same as it used to be on the previous > > versions w/

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 [v2]

2021-01-21 Thread Dmitry Markov
be disabled. > > Testing: > All our automated regression and JCK tests passed with the proposed change. Dmitry Markov has updated the pull request incrementally with one additional commit since the last revision: Use endComposition() instead of endCompositionNative() - C

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-21 Thread Dmitry Markov
On Wed, 20 Jan 2021 12:28:36 GMT, Alexey Ivanov wrote: >>> > Fix: >>> > It is necessary to take care of unconfirmed composition string once the >>> > IME is going to be disabled. >>> >>> The fix commits the unconfirmed composition string. Committing is better >>> than discarding. Is it possibl

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-20 Thread Dmitry Markov
On Wed, 20 Jan 2021 07:35:18 GMT, Ichiroh Takiguchi wrote: >> How do the native components work in that case like awt textarea or external >> apps like notepad? > >> How do the native components work in that case like awt textarea or external >> apps like notepad? > > I tested TextField+TextF

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-19 Thread Dmitry Markov
On Tue, 19 Jan 2021 12:44:22 GMT, Alexey Ivanov wrote: > > Fix: > > It is necessary to take care of unconfirmed composition string once the IME > > is going to be disabled. > > The fix commits the unconfirmed composition string. Committing is better than > discarding. Is it possible to preserv

Re: [EXTERNAL] RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-19 Thread Dmitry Markov
e, so I don't know the details. > I think the current code can change the candidate string after getting the > focus. > If possible, could you show me the test instructions ? > > Thanks, > Ichiroh Takiguchi > > On 2021-01-19 20:16, Dmitry Markov wrote: >> Problem d

RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-19 Thread Dmitry Markov
Problem description: The IME behaviour has changed starting from recent Windows 10 builds. In particular if the complex characters (Japanese, Chinese, etc.) are entered to some component and the focus is transferred to another component (which does not support the IM) the IM is disabled and the

Re: [OpenJDK 2D-Dev] [9] Review request for 8073400: Some Monospaced logical fonts have a different width

2016-03-21 Thread dmitry markov
mainly used for ensuring that the glyphs come from the right font which is mainly for locale reasons. If i18n see no problems then I am OK with this. -phil. On 02/17/2016 05:01 AM, dmitry markov wrote: Hello Phil, Thank you for the review. According to unicode table the characters u201c and

Re: [OpenJDK 2D-Dev] [9] Review request for 8073400: Some Monospaced logical fonts have a different width

2016-02-17 Thread dmitry markov
complained about does not hold up very well. I think you should also run this whole change+discussion by i18n-dev .. -phil. On 01/14/2016 02:32 AM, dmitry markov wrote: Hello, Could you review the fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8073400 webrev: htt