Re: Preedit string is still exist after focus change operation

2013-06-30 Thread Deven You
.html -- best regards, Anthony On 05/09/2013 11:33 AM, Deven You wrote: Hi All, I found there is a problem with our IMF(Input Methods Framework) when dealing with DBCS input like Chinese and Japanese on Windows 7 32bit env. The simple scenario is if your application has 2 windows and then: 1:

Re: Slovenia Pre Euro currency problem

2013-05-09 Thread Deven You
t! On 05/09/2013 02:18 PM, Deven You wrote: Hi All, There is a problem for display Slovenia Pre Euro currency, a test case[1] can reproduce this problem: expected: sl_SI Slovenian (Slovenia) currency example: Expected o/p: EUR 1.234,56 Actual o/p : EUR 1.234,56 sl_SI_EURO Slovenian (Sl

Slovenia Pre Euro currency problem

2013-05-08 Thread Deven You
Hi All, There is a problem for display Slovenia Pre Euro currency, a test case[1] can reproduce this problem: expected: sl_SI Slovenian (Slovenia) currency example: Expected o/p: EUR 1.234,56 Actual o/p : EUR 1.234,56 sl_SI_EURO Slovenian (Slovenia,Euro) currency example: Expected o/p: EUR 1

Re: Venezuela Currency has been changed to BS.F. now

2012-08-17 Thread Deven You
verify Best regards Jonathan On 08/10/2012 10:49 AM, Deven You wrote: Hi Yong and Masayoshi, I have updated the webrev[1] according to your comments, please review it. Thanks a lot! [1] http://cr.openjdk.java.net/~youdwei/ojdk-292/webrev.03/ <http://cr.openjdk.java.net/%7Eyoudwei/ojdk-

Re: Venezuela Currency has been changed to BS.F. now

2012-08-09 Thread Deven You
update the CR status. thanks, Yong On 2012/8/9 11:21, Deven You wrote: Hi Jeffrey, Thanks for your review. I have updated the webrev[1] according to your comments. To Masayoshi, After Jeffrey confirm this version of webrev please give your opinion as Jeffrey mentioned we need a reviewer.

Re: Venezuela Currency has been changed to BS.F. now

2012-08-08 Thread Deven You
ents in jdk/test/sun/text/resources/LocaleDataTest.java Change Set for your reference is http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/780b11d28712 BTW, I am not qualified to be a formal reviewer in JDK project. thanks, Yong On 2012/8/7 15:35, Deven You wrote: Hi All, I have searched from

Venezuela Currency has been changed to BS.F. now

2012-08-07 Thread Deven You
Hi All, I have searched from both wikipedia and windows config, the Venezuela currency symbol is already updated from "BsF. to " "Bs.F.". The ISO 4217 also map current Venezuela currency to "Bs.F.". I have made a patch[1] to reflect this change. Could anyone take a look! Thanks a lot! [1]

Re: hg: jdk8/tl/jdk: 7094176: (tz) Incorrect TimeZone display name when DST not applicable / disabled

2012-05-25 Thread Deven You
Hi Alan, Thanks for your reminder, I was going to point that this a manual test case and need someone guide me how to configure it as manual with jtreg. But I missed it by chance. So Masayoshi or someone else, I'd very appreciate if you could guide me how to configure a test case as manual i

Re: Locale patch for Slovenian date format data: dots are missed in the datetime for Slovanian

2012-05-25 Thread Deven You
missed in the datetime for Slovanian Reviewed-by: yhuang Please verify it and thank you all for reviewing. On 05/25/2012 10:19 AM, Deven You wrote: Hi Jffery, Thanks for your comments, I have updated the webrev[1], please review it! [1] http://cr.openjdk.java.net/~littlee/OJDK-126/webrev.02

Re: Locale patch for Slovenian date format data: dots are missed in the datetime for Slovanian

2012-05-24 Thread Deven You
tern "dd. y", // long date pattern the same as what in test file LocaleData. The change in LocaleData and LocaleDataTest.java are good. thanks for fixing the CR. Yong On 2012/5/24 13:51, Deven You wrote: Hi Jeffrey, I have updated the webrev[1] according t

Re: Incorrect TimeZone display name when DST not applicable / disabled

2012-05-23 Thread Deven You
Hi masayoshi, Could you review Yoshito and my replies and see if it is good to you? Thanks a lot! On 05/17/2012 11:04 AM, Deven You wrote: Hi Masayoshi, I think the workaround is good, but many customers may not know this fact and when they need change the timezone, they just select another

Re: Locale patch for Slovenian date format data: dots are missed in the datetime for Slovanian

2012-05-23 Thread Deven You
5=dd. y jdk/test/sun/text/resources/LocaleDataTest.java: In the end of comments @bug, add the bug number. thanks, Yong On 2012/5/21 15:41, Deven You wrote: Hi All, I think this patch is simple and straight forward, is anyone interested in taking a look? Thanks a lot! On 03/05/2012 01:52

Re: Locale patch for Slovenian date format data: dots are missed in the datetime for Slovanian

2012-05-21 Thread Deven You
Hi All, I think this patch is simple and straight forward, is anyone interested in taking a look? Thanks a lot! On 03/05/2012 01:52 PM, Deven wrote: Hi i18n-devs, I find there is a problem in Slovenian Locale. In Slovenian Locale, days in a date must with a dot '.', like Oct 23rd 2011 will

Re: Incorrect TimeZone display name when DST not applicable / disabled

2012-05-16 Thread Deven You
Hi Masayoshi, I think the workaround is good, but many customers may not know this fact and when they need change the timezone, they just select another time zone which does not support DST and ignore that the auto-adjust option should be checked first. To Yoshito, thanks for your informati

Re: Incorrect TimeZone display name when DST not applicable / disabled

2012-05-15 Thread Deven You
This is the MSDN reference[1] [1] http://msdn.microsoft.com/en-us/library/windows/desktop/ms724253%28v=vs.85%29.aspx On 05/16/2012 02:09 PM, Deven You wrote: Hi Masayoshi, This fix is only for Time zone which does not support DST. For your first question, the scenario is that when current

Re: Incorrect TimeZone display name when DST not applicable / disabled

2012-05-15 Thread Deven You
notes, but it seems to be gone some time ago. Is there any reason that the auto-adjust option needs to be kept turned off for the time zone? The fix seems OK for the India Standard Time case. But does the fix work if a time zone has Dynamic DST and starts observing DST some time in the futur

Re: Incorrect TimeZone display name when DST not applicable / disabled

2012-05-10 Thread Deven You
Anyone could take a look? On 05/07/2012 05:23 PM, Deven You wrote: Hi All, JDK displays incorrect TimeZone display name when DST (Daylight Saving Time) is disable in the native Time Zone settings on Windows XP/2003 platforms and the Time Zone does not support DST. Steps to re-create the

Incorrect TimeZone display name when DST not applicable / disabled

2012-05-07 Thread Deven You
Hi All, JDK displays incorrect TimeZone display name when DST (Daylight Saving Time) is disable in the native Time Zone settings on Windows XP/2003 platforms and the Time Zone does not support DST. Steps to re-create the problem 1. In the Windows Date and Time Properties dialog, set the time

Re: Performance patch for DateFormatSymbols.getZoneIndex(String)

2012-04-23 Thread Deven You
oshito noted, lastZoneIndex needs to be transient because DateFormatSymbols is serializable. Otherwise, the change looks good to me. Thanks, Masayoshi On 4/20/2012 11:56 AM, Deven You wrote: Yoshito, It is good to me for your suggestion. So Masayoshi, what is your opinion, is cache the las

Re: Performance patch for DateFormatSymbols.getZoneIndex(String)

2012-04-19 Thread Deven You
&& ID.equals(zoneStrings[lastZoneIndex ][0]) { return lastIndex; } // slow path for (int index = 0; index < zoneStrings.length; index++) { if (ID.equals(zoneStrings[index][0]) { lastZoneIndex = index; return index; } } } -Yoshito On 4/11/2012 3:02 AM

Re: Performance patch for DateFormatSymbols.getZoneIndex(String)

2012-04-11 Thread Deven You
e IDs are (supposed to be) case-sensitive. - Utilize auto-boxing/unboxing. Thanks, Masayoshi On 4/9/2012 12:10 PM, Deven You wrote: Hi i18n-devs, The getZoneIndex() method is expensive and it's performance depends on which timezone you're in. This is because the code steps throug

Performance patch for DateFormatSymbols.getZoneIndex(String)

2012-04-08 Thread Deven You
Hi i18n-devs, The getZoneIndex() method is expensive and it's performance depends on which timezone you're in. This is because the code steps through a list of timezones until it finds the current one. This is happening over and over again. An idea would be to either cache it or rewrite the wa