Re: Add some missing key maps

2012-06-07 Thread Charles Lee
test these issues. -- best regards, Anthony On 06/07/12 06:35, Charles Lee wrote: Thank you Naoto. The patch has been committed. On 06/07/2012 12:45 AM, Naoto Sato wrote: I double checked your patch and confirmed that the table lookup comes after those KANA specific handling, so it looks ok to me.

Re: Add some missing key maps

2012-06-06 Thread Charles Lee
Thank you Naoto. The patch has been committed. On 06/07/2012 12:45 AM, Naoto Sato wrote: I double checked your patch and confirmed that the table lookup comes after those KANA specific handling, so it looks ok to me. Naoto On 6/5/12 8:13 PM, Charles Lee wrote: Thank you Naoto. Thank you

Re: Add some missing key maps

2012-06-05 Thread Charles Lee
8n-dev@ mailing list. -- best regards, Anthony On 6/5/2012 7:19 AM, Charles Lee wrote: Hi awt-devs, There are some key map missing in the Japanese keyboard, for example: XK_Eisu_Shift, XK_Romaji, etc. I'd like to propose a patch @ http://cr.openjdk.java.net/~littlee/7174

Re: Fwd: Some differences on Window UDC area

2012-06-05 Thread Charles Lee
t;final" webrev http://cr.openjdk.java.net/~sherman/6183404/webrev which includes the update for both MS936 and GBK. -Sherman On 5/31/2012 9:47 PM, Xueming Shen wrote: On 5/31/2012 8:04 PM, Charles Lee wrote: Hi Sherman, Thank you for bring these out. The change is great because MS936.map is t

Re: Fwd: Some differences on Window UDC area

2012-05-31 Thread Charles Lee
Hi Sherman, Thank you for bring these out. The change is great because MS936.map is the same as mine :-) What about GBK.map? On 05/31/2012 03:25 PM, Xueming Shen wrote: Hi, Here is the webrev for the updated MS936.map change, which updated the mapping entries for 500+ EUDC code points with

Re: Fwd: Some differences on Window UDC area

2012-05-30 Thread Charles Lee
MS936 for JDK8. -Sherman On 5/23/2012 1:03 AM, Charles Lee wrote: Hi guys, We have a simple test case: for (String cname : new String[] { "GBK", "MS936", "GB18030" }) { Charset charset = Charset.forName(cname); System.out.println("charset: &

Re: Incorrect TimeZone display name when DST not applicable / disabled

2012-05-24 Thread Charles Lee
Hi Deven, The patch is committed @ Changeset: 71cf74329a9e Author:youdwei Date: 2012-05-25 13:28 +0800 URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71cf74329a9e 7094176: (tz) Incorrect TimeZone display name when DST not applicable / disabled Reviewed-by: okutsu Please verify it and

Re: Locale patch for Slovenian date format data: dots are missed in the datetime for Slovanian

2012-05-24 Thread Charles Lee
Hi Deven, The patch is committed @ Changeset: 85696e57d447 Author:youdwei Date: 2012-05-25 14:32 +0800 URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85696e57d447 7171028: dots are missed in the datetime for Slovanian Reviewed-by: yhuang Please verify it and thank you all for reviewi

Re: Fwd: Some differences on Window UDC area

2012-05-23 Thread Charles Lee
r.openjdk.java.net/~littlee/OJDK-63/webrev.00/Program.cs [3] http://cr.openjdk.java.net/~littlee/OJDK-63/webrev.00/gb2312Map.txt [4] http://cr.openjdk.java.net/~littlee/OJDK-63/webrev.00/gb18030Map.txt [5] http://cr.openjdk.java.net/~littlee/OJDK-63/webrev.00/GBK.map.new [6] http://cr.openjdk.java.net/

Re: Performance patch for DateFormatSymbols.getZoneIndex(String)

2012-04-24 Thread Charles Lee
Hi Deven, The patch has been committed @ Changeset: 2c35304e885a Author:youdwei Date: 2012-04-24 21:06 +0800 URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c35304e885a 7163865: Performance improvement for DateFormatSymbols.getZoneIndex(String) Reviewed-by: okutsu Please verify it.

Re: Performance patch for DateFormatSymbols.getZoneIndex(String)

2012-04-23 Thread Charles Lee
Hi Masayoshi, I'd like to sponsor this patch. But I did not figure out which repos the patch should go to. Is it jdk8-tl repository? On 04/23/2012 04:54 PM, Masayoshi Okutsu wrote: Looks good! Masayoshi On 4/23/2012 5:51 PM, Deven You wrote: Hi Masayoshi, Thanks for your reminder. I have

Re: Maybe some not useful code in sun.awt.im.InputContext

2011-12-05 Thread Charles Lee
On 12/06/2011 03:16 AM, Naoto Sato wrote: Hi Charles, Even though your finding below sounds right, I would not remove that piece of code, unless we are sure that it would not cause any regression. Naoto On 12/2/11 9:45 AM, Neil Richards wrote: On Fri, 2011-12-02 at 16:53 +0800, Charles Lee

Re: Fwd: Some differences on Window UDC area

2011-04-26 Thread Charles Lee
On 03/28/2011 11:06 PM, Alan Bateman wrote: Charles Lee wrote: : It looks similar. How can I find the patch quickly? I notice it says "the list is attached to this CR". Is it CR-6183404? Since cr has the pattern cr.openjdk.java.net/~username/id, how can I know who is the committ

Re: Fwd: Some differences on Window UDC area

2011-03-28 Thread Charles Lee
On 03/28/2011 11:06 PM, Alan Bateman wrote: Charles Lee wrote: : It looks similar. How can I find the patch quickly? I notice it says "the list is attached to this CR". Is it CR-6183404? Since cr has the pattern cr.openjdk.java.net/~username/id, how can I know who is the committ

Re: Fwd: Some differences on Window UDC area

2011-03-27 Thread Charles Lee
On 03/28/2011 10:38 AM, Alan Bateman wrote: Charles Lee wrote: Original Message Subject:Some differences on Window UDC area Date: Thu, 24 Mar 2011 09:34:20 +0800 From: Charles Lee To: i18n-dev@openjdk.java.net, litt...@linux.vnet.ibm.com Hi guys, Given

Fwd: Some differences on Window UDC area

2011-03-27 Thread Charles Lee
Original Message Subject:Some differences on Window UDC area Date: Thu, 24 Mar 2011 09:34:20 +0800 From: Charles Lee To: i18n-dev@openjdk.java.net, litt...@linux.vnet.ibm.com Hi guys, Given the test case below, some UDC are printed out. With some native