Re: Preedit string is still exist after focus change operation

2013-05-14 Thread Anthony Petrov
Hi Deven, I'm copying i18n-dev@ because they manage the IM code. As to a test, jtreg supports manual tests. See [1] for a lot of tips about using manual tests. An example of a manual test is at: jdk/test/java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter.java [1] http://openjdk.ja

Re: [7u12] Review request for 6789984: JPasswordField can not receive keyboard input

2012-11-15 Thread Anthony Petrov
(also cc'ing i18n-dev@) Approved, provided the code compiles and works as expected in the 7u release. -- best regards, Anthony On 11/15/12 12:43, Anton Litvinov wrote: Hello, Please review the following fix for a bug. It is a backport of the fix which is already reviewed and committed into

Re: [8] Review request for 6789984: JPasswordField can not receive keyboard input

2012-11-02 Thread Anthony Petrov
Hi Anton, I'm not an expert in IM code, but generally the changes look good to me. I'm also CC'ing i18n-dev@ to take a look at this fix. My only concern is that you're changing shared code here. Did you run any IM tests on other platforms to make sure no regressions are introduced? Also, co

Re: Add some missing key maps

2012-06-07 Thread Anthony Petrov
me solaris guys take a look on this issue? On 06/06/2012 01:56 AM, Naoto Sato wrote: The patch is changing the code to always convert VK_KANA_LOCK to XK_Kana_Lock keysym. Does this work with Solaris? Looks like there are some piece of code that specifically handles KANA_LOCK. Naoto On 6/5/12

Re: Add some missing key maps

2012-06-05 Thread Anthony Petrov
Hi Charles, I'm not an expert in keyboard-related code, but the code changes look good to me. I think I18n team might want to take a look at the fix as well, so I'm CC'ing the i18n-dev@ mailing list. -- best regards, Anthony On 6/5/2012 7:19 AM, Charles Lee wrote: Hi awt-devs, There ar