On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
On Mon, 4 Oct 2021 14:54:27 GMT, Alexander Zvegintsev
wrote:
> This fix simply describes that the `java.awt.im.InputContext` is a dummy
> implementation, which may not conform its spec.
This pull request has now been integrated.
Changeset: da8da3a1
Author:Alexander Zvegintse
On Tue, 12 Oct 2021 06:07:53 GMT, Sergey Bylokhov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> throw exceptions instead of doc change
>
> src/java.desktop/share/classes
> This fix simply describes that the `java.awt.im.InputContext` is a dummy
> implementation, which may not conform its spec.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
use Objects.requireNonNull
-
C
On Fri, 8 Oct 2021 00:16:29 GMT, Sergey Bylokhov wrote:
> I am fine with any solution but think the check will be simpler and safer,
> and later we will be able to change the behavior of some of these methods if
> it will be needed.
Makes sense. Testing is green with last code changes.
CSR lab
> This fix simply describes that the `java.awt.im.InputContext` is a dummy
> implementation, which may not conform its spec.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
throw exceptions instead of doc
On Mon, 4 Oct 2021 17:25:16 GMT, Sergey Bylokhov wrote:
> If the problem is in the validation of the parameters maybe we can enforce it?
It is one of possible solutions.
Also we have a following javadoc:
/**
* Constructs an InputContext.
* This method is protected so clients ca
This fix simply describes that the `java.awt.im.InputContext` is a dummy
implementation, which may not conform its spec.
-
Commit messages:
- rewording
- initial
Changes: https://git.openjdk.java.net/jdk/pull/5806/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5806&r
On Wed, 25 Aug 2021 12:47:41 GMT, Andrey Turbanov
wrote:
>> src/java.base/share/classes/java/net/URLPermission.java line 222:
>>
>>> 220:
>>> 221: List l = normalizeMethods(methods);
>>> 222: l.sort(null);
>>
>> I am not opposed to this change, but I find this is slightly more
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
There are a bunch of calls to `Collections.sort()` without a comparator
specified (at least in java.desktop):
https://github.com/openjdk/jdk/b
10 matches
Mail list logo
