On Sun, 28 Mar 2021 13:56:00 GMT, Alex Blewitt
wrote:
> 8264332: Use the blessed modifier order in jdk.charsets
This pull request has now been integrated.
Changeset: 364cce14
Author: Alex Blewitt
Committer: Aleksey Shipilev
URL: https://git.openjdk.java.net/jdk/commit/364cc
8264332: Use the blessed modifier order in jdk.charsets
-
Commit messages:
- 8264332: Use the blessed modifier order in jdk.charsets
Changes: https://git.openjdk.java.net/jdk/pull/3236/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3236&range=00
Issue: https://bugs.o
On Fri, 19 Mar 2021 18:23:00 GMT, Alex Blewitt
wrote:
> Additional changes found in `java.base` of `final private` -> `private
> final`. Filed with existing bug because it's the same module; can change to a
> different bug number if required.
This pull request has no
Additional changes found in `java.base` of `final private` -> `private final`.
Filed with existing bug because it's the same module; can change to a different
bug number if required.
-
Commit messages:
- 8263658: Use the blessed modifier order in java.base
Changes: https://git.ope
On Sat, 13 Mar 2021 22:45:30 GMT, Alex Blewitt
wrote:
> Sonar displays a warning message that modifiers should be declared in the
> order listed in the JLS; specifically, that isntead of using `final static`
> the `static final` should be preferred.
>
> This fixes th
On Thu, 18 Mar 2021 17:03:28 GMT, Claes Redestad wrote:
>> If I have other fixes for different modules, should I file PRs with the same
>> bug number e.g. "8263658: Use the blessed modifier order in
>> java.logging/java.desktop" or should we have separate bug numbers for them?
>
>> If I have ot
On Thu, 18 Mar 2021 16:50:39 GMT, Claes Redestad wrote:
>> Is that there to indicate a placeholder value that was once used and is kept
>> for documentation purposes? Should the corresponding JavaDoc be removed as
>> well? Should I do this in the same commit/PR as this one, or submit a new
>>
ing.
>
> https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=java&resolved=false&rules=java%3AS1124
Alex Blewitt has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous co
On Thu, 18 Mar 2021 14:50:43 GMT, Claes Redestad wrote:
>> Sonar displays a warning message that modifiers should be declared in the
>> order listed in the JLS; specifically, that isntead of using `final static`
>> the `static final` should be preferred.
>>
>> This fixes the issues in the `jav
On Thu, 18 Mar 2021 15:08:09 GMT, Aleksey Shipilev wrote:
>> src/java.base/share/classes/com/sun/security/ntlm/NTLMException.java line 52:
>>
>>> 50: * from server.
>>> 51: */
>>> 52: //public static final int DOMAIN_UNMATCH = 3;
>>
>> Maybe this one ought to be removed instead?
>
Sonar displays a warning message that modifiers should be declared in the order
listed in the JLS; specifically, that isntead of using `final static` the
`static final` should be preferred.
This fixes the issues in the `java.base` package for ease of reviewing.
https://sonarcloud.io/project/iss
11 matches
Mail list logo
