Re: RFR: 8282897: Fix call parameter to GetStringChars() in HostLocaleProviderAdapter_md.c

2022-03-10 Thread Aleksey Shipilev
On Thu, 10 Mar 2022 13:33:05 GMT, Zhengyu Gu wrote: > Please review this trivial patch to correct last parameter of > `GetStringChars()` call, which should be a `jboolean*`, instead of `jboolean` Looks fine to me. - Marked as reviewed by shade (Reviewer). PR: https://git.openjdk

Re: RFR: 8264332: Use the blessed modifier order in jdk.charsets

2021-03-29 Thread Aleksey Shipilev
On Sun, 28 Mar 2021 13:56:00 GMT, Alex Blewitt wrote: > 8264332: Use the blessed modifier order in jdk.charsets Marked as reviewed by shade (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3236

Re: RFR: 8263658: Use the blessed modifier order in java.base

2021-03-18 Thread Aleksey Shipilev
On Wed, 17 Mar 2021 12:31:22 GMT, Claes Redestad wrote: >> Sonar displays a warning message that modifiers should be declared in the >> order listed in the JLS; specifically, that isntead of using `final static` >> the `static final` should be preferred. >> >> This fixes the issues in the `jav

Re: RFR: 8263658: Use the blessed modifier order in java.base

2021-03-17 Thread Aleksey Shipilev
On Sat, 13 Mar 2021 22:45:30 GMT, Alex Blewitt wrote: > Sonar displays a warning message that modifiers should be declared in the > order listed in the JLS; specifically, that isntead of using `final static` > the `static final` should be preferred. > > This fixes the issues in the `java.base