Re: RFR: 8283698: Refactor Locale constructors used in src/test

2022-04-06 Thread Joe Wang
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote: > This is a follow-on task after deprecating the Locale constructors > (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are > simple replacements to Locale constructors with `Locale.of()` or Locale > constants, such as `

Re: RFR: 8283698: Refactor Locale constructors used in src/test

2022-04-06 Thread Joe Wang
On Thu, 7 Apr 2022 01:16:32 GMT, Naoto Sato wrote: >> test/jdk/java/text/Format/NumberFormat/CurrencyFormat.java line 63: >> >>> 61: Locale.of("it", "IT", "EURO"), >>> 62: Locale.forLanguageTag("de-AT"), >>> 63: Locale.forLanguageTag("fr-CH"), >> >> Use the n

Re: RFR: 8283698: Refactor Locale constructors used in src/test

2022-04-06 Thread Joe Wang
On Thu, 7 Apr 2022 01:16:27 GMT, Naoto Sato wrote: >> test/jdk/java/text/Format/DateFormat/DateFormatRoundTripTest.java line 81: >> >>> 79: >>> 80: /** >>> 81: * Parse a name like "fr_FR" into Locale.of("fr", "FR", ""); >> >> Locale.France? > > The test code parses the input string (e

Re: RFR: 8283698: Refactor Locale constructors used in src/test

2022-04-06 Thread Naoto Sato
On Thu, 7 Apr 2022 00:09:58 GMT, Joe Wang wrote: >> This is a follow-on task after deprecating the Locale constructors >> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are >> simple replacements to Locale constructors with `Locale.of()` or Locale >> constants, such as

Re: RFR: 8283698: Refactor Locale constructors used in src/test

2022-04-06 Thread Joe Wang
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote: > This is a follow-on task after deprecating the Locale constructors > (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are > simple replacements to Locale constructors with `Locale.of()` or Locale > constants, such as `

Re: RFR: 8283698: Refactor Locale constructors used in src/test

2022-04-06 Thread Joe Wang
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote: > This is a follow-on task after deprecating the Locale constructors > (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are > simple replacements to Locale constructors with `Locale.of()` or Locale > constants, such as `

Re: RFR: 8283698: Refactor Locale constructors used in src/test

2022-04-06 Thread Joe Wang
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote: > This is a follow-on task after deprecating the Locale constructors > (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are > simple replacements to Locale constructors with `Locale.of()` or Locale > constants, such as `

Re: RFR: 8284444: Sting typo [v3]

2022-04-06 Thread Markus Grönlund
On Wed, 6 Apr 2022 16:47:17 GMT, Daniel Jeliński wrote: >> This patch adds missing `r` in `string`s > > Daniel Jeliński has updated the pull request incrementally with two > additional commits since the last revision: > > - revert xalan changes > - revert icu changes JFR changes look fine, t

Re: RFR: 8283698: Refactor Locale constructors used in src/test

2022-04-06 Thread Iris Clark
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote: > This is a follow-on task after deprecating the Locale constructors > (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are > simple replacements to Locale constructors with `Locale.of()` or Locale > constants, such as `

Re: RFR: 8284444: Sting typo [v3]

2022-04-06 Thread Alexey Ivanov
On Wed, 6 Apr 2022 16:47:17 GMT, Daniel Jeliński wrote: >> This patch adds missing `r` in `string`s > > Daniel Jeliński has updated the pull request incrementally with two > additional commits since the last revision: > > - revert xalan changes > - revert icu changes The changes look fine to

Re: RFR: 8284444: Sting typo [v3]

2022-04-06 Thread Kevin Rushforth
On Wed, 6 Apr 2022 14:12:49 GMT, Daniel Jeliński wrote: >> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties >> line 63: >> >>> 61: message.creating-association-with-null-extension=Creating association >>> with null extension. >>> 62: message.wrong-tool-v

Re: RFR: 8284444: Sting typo [v3]

2022-04-06 Thread Kevin Rushforth
On Wed, 6 Apr 2022 16:47:17 GMT, Daniel Jeliński wrote: >> This patch adds missing `r` in `string`s > > Daniel Jeliński has updated the pull request incrementally with two > additional commits since the last revision: > > - revert xalan changes > - revert icu changes The `jpackage` part of t

RFR: 8283698: Refactor Locale constructors used in src/test

2022-04-06 Thread Naoto Sato
This is a follow-on task after deprecating the Locale constructors (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are simple replacements to Locale constructors with `Locale.of()` or Locale constants, such as `Locale.US`. - Commit messages: - 8283698: Refa

Re: RFR: 8284444: Sting typo [v2]

2022-04-06 Thread Naoto Sato
On Wed, 6 Apr 2022 16:48:38 GMT, Daniel Jeliński wrote: >> src/java.base/share/classes/jdk/internal/icu/text/StringPrep.java line 63: >> >>> 61: * http://www.ietf.org/rfc/rfc3454.txt";>RFC 3454. >>> 62: * StringPrep prepares Unicode strings for use in network protocols. >>> 63: * Profiles of

Re: RFR: 8284444: Sting typo [v2]

2022-04-06 Thread Daniel Jeliński
On Wed, 6 Apr 2022 15:49:06 GMT, Naoto Sato wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert liblcms changes > > src/java.base/share/classes/jdk/internal/icu/text/StringPrep.java line 63: > >> 61: * http

Re: RFR: 8284444: Sting typo [v3]

2022-04-06 Thread Daniel Jeliński
> This patch adds missing `r` in `string`s Daniel Jeliński has updated the pull request incrementally with two additional commits since the last revision: - revert xalan changes - revert icu changes - Changes: - all: https://git.openjdk.java.net/jdk/pull/8125/files - new: htt

Re: RFR: 8284444: Sting typo [v2]

2022-04-06 Thread Naoto Sato
On Wed, 6 Apr 2022 14:12:17 GMT, Daniel Jeliński wrote: >> This patch adds missing `r` in `string`s > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > Revert liblcms changes src/java.base/share/classes/jdk/internal/icu/tex

Re: RFR: 8284444: Sting typo [v2]

2022-04-06 Thread Daniel Jeliński
On Wed, 6 Apr 2022 13:36:05 GMT, Alexey Ivanov wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert liblcms changes > > src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties

Re: RFR: 8284444: Sting typo [v2]

2022-04-06 Thread Daniel Jeliński
> This patch adds missing `r` in `string`s Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision: Revert liblcms changes - Changes: - all: https://git.openjdk.java.net/jdk/pull/8125/files - new: https://git.openjdk.java.

Re: RFR: 8284444: Sting typo

2022-04-06 Thread Daniel Jeliński
On Wed, 6 Apr 2022 13:38:03 GMT, Alexey Ivanov wrote: >> This patch adds missing `r` in `string`s > > src/java.desktop/share/native/liblcms/cmstypes.c line 3668: > >> 3666: // Auxiliary, read an string specified as count + string >> 3667: static >> 3668: cmsBool ReadCountAndString(struct _cms_t

Re: RFR: 8284444: Sting typo

2022-04-06 Thread Alexey Ivanov
On Wed, 6 Apr 2022 12:07:30 GMT, Daniel Jeliński wrote: > This patch adds missing `r` in `string`s src/java.desktop/share/native/liblcms/cmstypes.c line 3668: > 3666: // Auxiliary, read an string specified as count + string > 3667: static > 3668: cmsBool ReadCountAndString(struct _cms_typehand

Re: RFR: 8284444: Sting typo

2022-04-06 Thread Kevin Rushforth
On Wed, 6 Apr 2022 12:07:30 GMT, Daniel Jeliński wrote: > This patch adds missing `r` in `string`s This PR cuts across many areas, so will need multiple reviewers. Regarding the LCMS file, we typically don't make these kind of changes in third-party code, since it will cause our code to diverg

RFR: 8284444: Sting typo

2022-04-06 Thread Daniel Jeliński
This patch adds missing `r` in `string`s - Commit messages: - Fix sting typo Changes: https://git.openjdk.java.net/jdk/pull/8125/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8125&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-828 Stats: 25 lines in