On Mon, 28 Mar 2022 21:20:00 GMT, Alisen Chung wrote:
> This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
This pull request has now been integrated.
Changeset: 634800a5
Author:Alisen Chung
Committer: Naoto Sato
URL:
https://git.openjdk.java.net/jdk/commit/634800a536e7f9
On Mon, 28 Mar 2022 21:20:00 GMT, Alisen Chung wrote:
> This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
LGTM
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8005
On Mon, 28 Mar 2022 21:06:35 GMT, Roger Riggs wrote:
>> While it is true for completeness, I would limit the addition of new method
>> as little as possible, because there are already several ways to obtain a
>> Locale object.
>
> As with other varargs method calls, it is possible to pass an ar
> Proposing to deprecate the constructors in the `java.util.Locale` class.
> There is already a factory method and a builder to return singletons, so
> there is no need to have constructors anymore unless one purposefully wants
> to create `ill-formed` Locale objects, which is discouraged. We ca
On Mon, 28 Mar 2022 21:20:00 GMT, Alisen Chung wrote:
> This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
I confirm that this is an exact backout of
[JDK-8280400](https://bugs.openjdk.java.net/browse/JDK-8280400).
-
Marked as reviewed by kcr (Author).
PR: https://git.
This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
-
Commit messages:
- Revert "8280400: JDK 19 L10n resource files update - msgdrop 10"
Changes: https://git.openjdk.java.net/jdk/pull/8005/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8005&range=00
Issue:
On Mon, 28 Mar 2022 16:00:14 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/util/Locale.java line 819:
>>
>>> 817: * @since 19
>>> 818: */
>>> 819: public static Locale of(String... fields) {
>>
>> Arguably, there should be `Locale.of` overloads taking 0 to 4 arguments
On Mon, 28 Mar 2022 18:51:30 GMT, Naoto Sato wrote:
>> Proposing to deprecate the constructors in the `java.util.Locale` class.
>> There is already a factory method and a builder to return singletons, so
>> there is no need to have constructors anymore unless one purposefully wants
>> to creat
On Mon, 28 Mar 2022 17:13:44 GMT, Lance Andersen wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> New unit test. IllegalArgumentException.
>
> test/jdk/java/util/Locale/TestOf.java line 79:
>
>> 77: @Test (expect
> Proposing to deprecate the constructors in the `java.util.Locale` class.
> There is already a factory method and a builder to return singletons, so
> there is no need to have constructors anymore unless one purposefully wants
> to create `ill-formed` Locale objects, which is discouraged. We ca
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
This pull request has now been integrated.
Changeset: c0aecd15
Author:Alisen Chung
Committer: Naoto Sato
URL:
https://git.openjdk.java.net/jdk/commit/c0aecd15ae8d7abf37901f785fccaff2317c3b23
Stat
On Mon, 28 Mar 2022 17:02:33 GMT, Naoto Sato wrote:
>> Proposing to deprecate the constructors in the `java.util.Locale` class.
>> There is already a factory method and a builder to return singletons, so
>> there is no need to have constructors anymore unless one purposefully wants
>> to creat
> Proposing to deprecate the constructors in the `java.util.Locale` class.
> There is already a factory method and a builder to return singletons, so
> there is no need to have constructors anymore unless one purposefully wants
> to create `ill-formed` Locale objects, which is discouraged. We ca
On Mon, 28 Mar 2022 11:52:38 GMT, Claes Redestad wrote:
> This address a minor inefficiency in that the `ZoneRules` of any `ZoneOffset`
> (and some `ZoneRegion`s) allocate `lastRulesCache` unnecessarily.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jd
On Sun, 27 Mar 2022 08:45:01 GMT, ExE Boss wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed a build failure
>
> src/java.base/share/classes/java/util/Locale.java line 819:
>
>> 817: * @since 19
>> 818:
On Sat, 26 Mar 2022 11:30:53 GMT, Lance Andersen wrote:
> One suggestion As part of the PR, we should probably update
> test/jdk/java/util/Locale/LocaleTest.java. or perhaps add a new test for
> Locale.of() for completeness.
Thanks, Lance. Sure, I will add some new unit tests for the new metho
On Mon, 28 Mar 2022 11:52:38 GMT, Claes Redestad wrote:
> This address a minor inefficiency in that the `ZoneRules` of any `ZoneOffset`
> (and some `ZoneRegion`s) allocate `lastRulesCache` unnecessarily.
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.java
This address a minor inefficiency in that the `ZoneRules` of any `ZoneOffset`
(and some `ZoneRegion`s) allocate `lastRulesCache` unnecessarily.
-
Commit messages:
- Merge branch 'master' into lastRulesCache
- Avoid allocating unused lastRulesCaches
Changes: https://git.openjdk.jav
18 matches
Mail list logo
