Re: RFR: 8257733: Move module-specific data from make to respective module [v6]

2022-03-15 Thread Alan Bateman
Magnus, This proposal does not address the previous concerns. As before, you are proposing to put the data files used to generate the classes for jdk.localedata and jdk.charsets into src/java.base and I don't think we should do that. I really think this PR needs to be withdraw n or closed unt

Re: RFR: 8257733: Move module-specific data from make to respective module [v6]

2022-03-15 Thread Magnus Ihse Bursie
On Tue, 15 Mar 2022 23:50:20 GMT, Magnus Ihse Bursie wrote: >> A lot (but not all) of the data in make/data is tied to a specific module. >> For instance, the publicsuffixlist is used by java.base, and fontconfig by >> java.desktop. (A few directories, like mainmanifest, is *actually* used by

Re: RFR: 8257733: Move module-specific data from make to respective module [v5]

2022-03-15 Thread Magnus Ihse Bursie
On Mon, 18 Jan 2021 13:47:20 GMT, Magnus Ihse Bursie wrote: >> A lot (but not all) of the data in make/data is tied to a specific module. >> For instance, the publicsuffixlist is used by java.base, and fontconfig by >> java.desktop. (A few directories, like mainmanifest, is *actually* used by

Re: RFR: 8257733: Move module-specific data from make to respective module [v6]

2022-03-15 Thread Magnus Ihse Bursie
> A lot (but not all) of the data in make/data is tied to a specific module. > For instance, the publicsuffixlist is used by java.base, and fontconfig by > java.desktop. (A few directories, like mainmanifest, is *actually* used by > make for the whole build.) > > These data files should move t

Re: RFR: 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

2022-03-15 Thread Zhengyu Gu
On Thu, 10 Mar 2022 19:46:28 GMT, Naoto Sato wrote: >> Please review this small patch that fixes early `CHECK_NULL_RETURN` results >> not releasing native `jchar` array returned by `GetStringChars()`. > > LGTM. Thanks, @naotoj @AlanBateman - PR: https://git.openjdk.java.net/jdk/pu

Re: RFR: 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

2022-03-15 Thread Alan Bateman
On Thu, 10 Mar 2022 18:40:13 GMT, Zhengyu Gu wrote: > Please review this small patch that fixes early `CHECK_NULL_RETURN` results > not releasing native `jchar` array returned by `GetStringChars()`. Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pul

Integrated: 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

2022-03-15 Thread Zhengyu Gu
On Thu, 10 Mar 2022 18:40:13 GMT, Zhengyu Gu wrote: > Please review this small patch that fixes early `CHECK_NULL_RETURN` results > not releasing native `jchar` array returned by `GetStringChars()`. This pull request has now been integrated. Changeset: 2cddf3f5 Author:Zhengyu Gu URL:

Re: RFR: 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

2022-03-15 Thread Zhengyu Gu
On Thu, 10 Mar 2022 18:40:13 GMT, Zhengyu Gu wrote: > Please review this small patch that fixes early `CHECK_NULL_RETURN` results > not releasing native `jchar` array returned by `GetStringChars()`. Friendly ping. May I have a second review, please! - PR: https://git.openjdk.java.