On Mon, 7 Mar 2022 20:36:36 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>> caching
On Mon, 7 Mar 2022 20:36:36 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>> caching
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
This pull request has now been integrated.
Changeset: ccad3923
Author:Matteo Baccan
Committer: Magnus Ihse Bursie
URL:
On Mon, 7 Mar 2022 20:36:36 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>> caching
On Mon, 7 Mar 2022 17:09:37 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>> caching
> Several attempts have been made to improve Formatter's numeric performance by
> caching the current Locale zero. Such fixes, however, ignore the real issue,
> which is the slowness of fetching DecimalFormatSymbols. By directly caching
> DecimalFormatSymbols in the Formatter, this enhancement s
On Mon, 7 Mar 2022 18:20:43 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The incre
On Mon, 7 Mar 2022 18:30:28 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since
On Mon, 7 Mar 2022 17:04:25 GMT, Joe Wang wrote:
>> Is `IsoBased` is fine with me. "isISOLike" is too vague.
>
> That matches the javadoc as well, that it "supports ISO based fields".
Renamed the new method to `isIsoBased()`. Modified the CSR accordingly.
-
PR: https://git.openjdk
> Supporting `IsoFields` temporal fields in chronologies that are similar to
> ISO chronology. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by
> Several attempts have been made to improve Formatter's numeric performance by
> caching the current Locale zero. Such fixes, however, ignore the real issue,
> which is the slowness of fetching DecimalFormatSymbols. By directly caching
> DecimalFormatSymbols in the Formatter, this enhancement s
On Mon, 7 Mar 2022 16:40:15 GMT, Lance Andersen wrote:
>> Hi
>>
>> I have reviewed the code for removing double semicolons at the end of lines
>>
>> all the best
>> matteo
>
> What problem are you having editing the PR header? You should be able to do
> so as the author of the PR
@LanceAnde
On Mon, 7 Mar 2022 17:12:25 GMT, Magnus Ihse Bursie wrote:
> TheShermanTanker is not the author of this PR, he's just assisting the author
> by creating the JBS issue.
Ah, that explains it then.
-
PR: https://git.openjdk.java.net/jdk/pull/7268
On Mon, 7 Mar 2022 03:00:45 GMT, Roger Riggs wrote:
>> OK, I propose `isIsoBased()` for the name, which I initially thought of. If
>> there is no objection, I will modify the spec/impl.
>
> Is `IsoBased` is fine with me. "isISOLike" is too vague.
That matches the javadoc as well, that it "supp
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
But as the JBS title and PR title now match, this is a moot point.
-
PR: https://git.openjdk.java.net/jdk/pull/726
On Mon, 7 Mar 2022 16:40:15 GMT, Lance Andersen wrote:
> What problem are you having editing the PR header? You should be able to do
> so as the author of the PR
Exactly. You should see an "Edit" button near the right edge of the PR title.
See the attached image:
?
>>
>> Declarations should be private unless there is a package need.
>> In this case, the only access to should be via the
On Sat, 5 Mar 2022 06:49:16 GMT, Julian Waters wrote:
> Should I change the JBS issue title to match the PR title, or is it preferred
> for the PR title to change?
They need to match. You can either do it manually, or change the title to just
the bug number and the bot will change it for you.
On Fri, 4 Mar 2022 20:04:42 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Too many 'the'
>
> src/java.base/share/classes/java/util/Formatter.java line 2025:
>
>> 2023:
>> 2024: // Caching zer
On Mon, 7 Mar 2022 00:33:53 GMT, Naoto Sato wrote:
>>> will now try and update/use this cached class level static state DFS. That
>>> would thus require some kind of thread safety semantics to be implemented
>>> for this new getDecimalFormatSymbols(Locale) method, isn't it?
>>
>> A bit more cl
On Mon, 7 Mar 2022 08:25:19 GMT, Stephen Colebourne
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Too many 'the'
>
> Just to note that there is also some caching in `DecimalStyle`. It might be
> possible to reuse
On Fri, 4 Mar 2022 19:02:29 GMT, Naoto Sato wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Too many 'the'
>
> src/java.base/share/classes/java/util/Formatter.java line 2026:
>
>> 2024: // Caching zero.
>> 2025:
On Fri, 4 Mar 2022 21:14:26 GMT, Roger Riggs wrote:
>> As a separate/future issue, perhaps the constructors should be deprecated to
>> nudge people to using the static `getInstance` methods.
>
> Would it be just as effective and improve performance more broadly to cache
> in DecimalFormatSymbol
On Fri, 4 Mar 2022 21:17:50 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>> caching
28 matches
Mail list logo
