Re: RFR: 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate [v3]

2022-03-06 Thread Roger Riggs
On Mon, 7 Mar 2022 01:27:39 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/time/chrono/Chronology.java line 794: >> >>> 792: * @since 19 >>> 793: */ >>> 794: default boolean supportsIsoFields() { >> >> I'm not a fan of this name, as it is inconsistent with the rest of

Re: RFR: 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate [v3]

2022-03-06 Thread Naoto Sato
On Sun, 6 Mar 2022 17:12:31 GMT, Stephen Colebourne wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addresses review comments > > src/java.base/share/classes/java/time/chrono/Chronology.java line 794: > >> 792:

Re: RFR: JDK-8282625 Formatter caches Locale/DecimalFormatSymbols poorly [v3]

2022-03-06 Thread Naoto Sato
On Sun, 6 Mar 2022 15:00:47 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/java/util/Formatter.java line 2012: >> >>> 2010: public final class Formatter implements Closeable, Flushable { >>> 2011: // Caching DecimalFormatSymbols >>> 2012: static DecimalFormatSymbols DFS = null;

Re: RFR: 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate [v3]

2022-03-06 Thread Stephen Colebourne
On Fri, 4 Mar 2022 23:05:56 GMT, Naoto Sato wrote: >> Supporting `IsoFields` temporal fields in chronologies that are similar to >> ISO chronology. Corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revi

Re: RFR: JDK-8282625 Formatter caches Locale/DecimalFormatSymbols poorly [v3]

2022-03-06 Thread Jaikiran Pai
On Sat, 5 Mar 2022 14:20:40 GMT, Jaikiran Pai wrote: > will now try and update/use this cached class level static state DFS. That > would thus require some kind of thread safety semantics to be implemented for > this new getDecimalFormatSymbols(Locale) method, isn't it? A bit more closer look