On Mon, 24 Jan 2022 06:03:42 GMT, Prasanta Sadhukhan
wrote:
>> The changes done under JDK-8278175 suppress on a per-file basis various
>> missing comments that would otherwise trigger doclint warnings. Fixed them
>> so as to remove the doclint:missing warnings.
>
> Prasanta Sadhukhan has updat
Hi Naoto,
Nice use of regular expression! Saves a lot of description if I would
just follow the regex pattern.
Question:
The 2nd and 3rd statements defined the requestedTemplate, does
it imply the characters listed in the snippet are the only ones that are
valid, in other words, can o
Updated the CSR (https://bugs.openjdk.java.net/browse/JDK-8243445), by
adding a regular expression for the requested template. This way, it is
less depending on the LDML specification.
Naoto
On 1/21/22 2:39 PM, Naoto Sato wrote:
Thanks, Joe.
Good point. I will elaborate the pattern template
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
This pull request has now been integrated.
Changeset: 8e82d002
Author:Joe Darcy
URL:
https://git.openjdk.java.net/jdk/commit/8e82d0021c119b7793870811fad37d7659c1174d
Stat
> Use presumed syntax that will be introduced by JDK-8280488.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains three additional commits since t
On Fri, 21 Jan 2022 19:28:21 GMT, Daniel Jeliński wrote:
> Reported by clang-tidy. Verified manually by running
>
> Calendar c = Calendar.getInstance();
> System.out.println (c.getDisplayNames(Calendar.MONTH,
> Calendar.SHORT_STANDALONE, Locale.getDefault()));
>
> with `-Djava.
On Mon, 24 Jan 2022 06:03:42 GMT, Prasanta Sadhukhan
wrote:
>> The changes done under JDK-8278175 suppress on a per-file basis various
>> missing comments that would otherwise trigger doclint warnings. Fixed them
>> so as to remove the doclint:missing warnings.
>
> Prasanta Sadhukhan has updat
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
Marked as reviewed by aivanov (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7189
On Mon, 24 Jan 2022 11:33:18 GMT, Pavel Rappo wrote:
> > Use presumed syntax that will be introduced by JDK-8280488.
>
> Is that a wrong bug? If you are talking about module-prefix syntax for links,
> then it was introduced in JDK 15; JDK-8164408: Add module support for @see,
> @link and @link
On Mon, 24 Jan 2022 11:34:04 GMT, Alexey Ivanov wrote:
>> Since it is mentioned in other places, I would rather not scrap it. Also,
>> since in most places it is mentioned as a non-link value, I chose to modify
>> it.
>
> The `` element does not create a link, it uses monospace font to render
On Mon, 24 Jan 2022 11:28:06 GMT, Prasanta Sadhukhan
wrote:
>> If `ShellFolder` remains mentioned, I'd rather use
>> `ShellFolder` as it was done originally.
>>
>> I guess Sergey challenged the fact of referencing `ShellFolder`. The fact
>> that it could be `ShellFolder` rather than `File` is
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
Is that a wrong bug? If you are talking about module-prefix syntax for links,
then it was introduced in JDK 15; JDK-8164408: Add module support for @see,
@link and @linkplain javado
On Mon, 24 Jan 2022 10:51:00 GMT, Alexey Ivanov wrote:
>> It is already mentioned in getSystemDisplayName, getSystemTypeDescription,
>> getSystemIcon, isRoot. Anyways, I have removed the linkage for the new
>> addition as it will not be able to resolve.
>
> If `ShellFolder` remains mentioned, I
On Mon, 24 Jan 2022 11:00:37 GMT, Daniel Fuchs wrote:
> LGTM. I hope in the future IDEs will pick that rule up and offer some help
> when writing `{@link }` `@see`...
They will do it quicker, if you create new or support existing bugs in their
bug trackers.
-
PR: https://git.open
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
Marked as reviewed by dfuchs (Reviewer).
LGTM. I hope in the future IDEs will pick that rule up and offer some help when
writing `{@link }` `@see`...
-
PR: https://git
On Mon, 24 Jan 2022 06:00:02 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java
>> line 353:
>>
>>> 351: * File(parent, fileName) except when the parent and child
>>> are both
>>> 352: * special folders, in which case the Fil
On Fri, 21 Jan 2022 19:28:21 GMT, Daniel Jeliński wrote:
> Reported by clang-tidy. Verified manually by running
>
> Calendar c = Calendar.getInstance();
> System.out.println (c.getDisplayNames(Calendar.MONTH,
> Calendar.SHORT_STANDALONE, Locale.getDefault()));
>
> with `-Djava.
17 matches
Mail list logo
