Re: RFR: 8277398: javac does not accept encoding name COMPAT [v2]

2021-11-24 Thread Ichiroh Takiguchi
On Wed, 24 Nov 2021 04:08:43 GMT, Ichiroh Takiguchi wrote: >> ncoding name COMPAT was defined for operating system encoding by JEP-400. >> https://openjdk.java.net/jeps/400 >> But java does not accept "-encoding COMPAT". > > Ichiroh Takiguchi has updated the pull request incrementally with one

Re: RFR: 8177819: DateTimeFormatterBuilder zone parsing should recognise DST [v3]

2021-11-24 Thread Joe Wang
On Wed, 24 Nov 2021 23:25:22 GMT, Naoto Sato wrote: >> This fix intends to honor the type (std/dst/generic) of parsed zone name for >> selecting the offset at the overlap. Corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with two additional > co

Re: RFR: 8277398: javac does not accept encoding name COMPAT [v2]

2021-11-24 Thread Naoto Sato
On Wed, 24 Nov 2021 04:08:43 GMT, Ichiroh Takiguchi wrote: >> ncoding name COMPAT was defined for operating system encoding by JEP-400. >> https://openjdk.java.net/jeps/400 >> But java does not accept "-encoding COMPAT". > > Ichiroh Takiguchi has updated the pull request incrementally with one

Re: RFR: 8177819: DateTimeFormatterBuilder zone parsing should recognise DST [v2]

2021-11-24 Thread Naoto Sato
On Wed, 24 Nov 2021 21:27:15 GMT, Joe Wang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refined wording > > src/java.base/share/classes/java/time/format/DateTimeFormatter.java line 509: > >> 507: * parsed from t

Re: RFR: 8177819: DateTimeFormatterBuilder zone parsing should recognise DST [v2]

2021-11-24 Thread Naoto Sato
On Tue, 23 Nov 2021 23:50:36 GMT, Naoto Sato wrote: >> This fix intends to honor the type (std/dst/generic) of parsed zone name for >> selecting the offset at the overlap. Corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > co

Re: RFR: 8177819: DateTimeFormatterBuilder zone parsing should recognise DST [v3]

2021-11-24 Thread Naoto Sato
> This fix intends to honor the type (std/dst/generic) of parsed zone name for > selecting the offset at the overlap. Corresponding CSR has also been drafted. Naoto Sato has updated the pull request incrementally with two additional commits since the last revision: - Replaced integer literals.

Re: RFR: 8277398: javac does not accept encoding name COMPAT [v2]

2021-11-24 Thread Ichiroh Takiguchi
On Wed, 24 Nov 2021 18:35:45 GMT, Naoto Sato wrote: >> Ichiroh Takiguchi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8277398: javac does not accept encoding name COMPAT > > Sorry, but I am kind of lost what you are expecting here. Al

Re: RFR: 8177819: DateTimeFormatterBuilder zone parsing should recognise DST [v2]

2021-11-24 Thread Joe Wang
On Tue, 23 Nov 2021 23:50:36 GMT, Naoto Sato wrote: >> This fix intends to honor the type (std/dst/generic) of parsed zone name for >> selecting the offset at the overlap. Corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > co

Re: RFR: 8274640: Cleanup unnecessary null comparison before instanceof check in java.desktop

2021-11-24 Thread Andrey Turbanov
On Sat, 11 Sep 2021 14:59:21 GMT, Andrey Turbanov wrote: > Updated code checks both non-null and instance of a class in java.desktop > module classes. > The checks and explicit casts could also be replaced with pattern matching > for the instanceof operator. > Similar cleanups > 1. [JDK-827348

Re: RFR: 8274784: jshell: Garbled character was displayed by System.out.println(...) on Japanese Windows [v2]

2021-11-24 Thread Naoto Sato
On Wed, 24 Nov 2021 03:05:32 GMT, Ichiroh Takiguchi wrote: >> JEP-400 was implemented by JDK18-b13. >> After JDK18-b13, garbled character was displayed by following code on >> Japanese Windows' command prompt. >> >> System.out.println("\u3042") >> >> Japanese "A" should be display ed, but gar

Re: RFR: 8277398: javac does not accept encoding name COMPAT [v2]

2021-11-24 Thread Ichiroh Takiguchi
On Wed, 24 Nov 2021 08:47:54 GMT, Alan Bateman wrote: >> Ichiroh Takiguchi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8277398: javac does not accept encoding name COMPAT > > I see this PR has been re-purposed to add "COMPAT" as a ch

Re: RFR: 8277398: javac does not accept encoding name COMPAT [v2]

2021-11-24 Thread Naoto Sato
On Wed, 24 Nov 2021 04:08:43 GMT, Ichiroh Takiguchi wrote: >> ncoding name COMPAT was defined for operating system encoding by JEP-400. >> https://openjdk.java.net/jeps/400 >> But java does not accept "-encoding COMPAT". > > Ichiroh Takiguchi has updated the pull request incrementally with one

Re: RFR: 8277398: javac does not accept encoding name COMPAT [v2]

2021-11-24 Thread Alan Bateman
On Wed, 24 Nov 2021 04:08:43 GMT, Ichiroh Takiguchi wrote: >> ncoding name COMPAT was defined for operating system encoding by JEP-400. >> https://openjdk.java.net/jeps/400 >> But java does not accept "-encoding COMPAT". > > Ichiroh Takiguchi has updated the pull request incrementally with one