RFR: 8277398: javac does not accept encoding name COMPAT

2021-11-18 Thread Ichiroh Takiguchi
ncoding name COMPAT was defined for operating system encoding by JEP-400. https://openjdk.java.net/jeps/400 But java does not accept "-encoding COMPAT". - Commit messages: - 8277398: javac does not accept encoding name COMPAT Changes: https://git.openjdk.java.net/jdk/pull/6475/files

RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-18 Thread Brent Christian
Here are the code changes for the "Deprecate finalizers in the standard Java API" portion of JEP 421 ("Deprecate Finalization for Removal") for code review. This change makes the indicated deprecations, and updates the API spec for JEP 421. It also updates the relevant @SuppressWarning annotatio

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v3]

2021-11-18 Thread Andrey Turbanov
On Thu, 18 Nov 2021 05:36:29 GMT, Sergey Bylokhov wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8274893: Update java.desktop classes to use try-with-resources >> fix review comments > > src/java.desktop/shar

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v3]

2021-11-18 Thread Andrey Turbanov
> 8274893: Update java.desktop classes to use try-with-resources Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8274893: Update java.desktop classes to use try-with-resources fix review comments - Changes: - all:

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v2]

2021-11-18 Thread Andrey Turbanov
On Thu, 18 Nov 2021 05:30:59 GMT, Sergey Bylokhov wrote: >> Andrey Turbanov has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8274893: Update java.desktop classes to use try-with-resources >>close nested resources too >> - [PATCH] U

Integrated: 8276794: Change nested classes in java.desktop to static nested classes

2021-11-18 Thread Andrey Turbanov
On Thu, 14 Oct 2021 07:47:33 GMT, Andrey Turbanov wrote: > Non-static classes hold a link to their parent classes, which in many cases > can be avoided. > I updated only private and package-private classes. Didn't touch > public/protected to not break external code. > Similar cleanup in java.ba

Re: Supporting charset GB18030-2005

2021-11-18 Thread Pushkar N Kulkarni
Hi Alan, > We could start out by adding GB18030-2005, as you suggest. Sure. > A potential next step would be to rename GB13080 to GB13080-2000, with > "GB13080" as an alias. As it stands, the charset name is "GB13080" with > "GB13080-2000" as an alias so it should be compatible with