Re: RFR: 8269698: Specification for methods of java.awt.im.InputContext should mention that they do nothing

2021-10-07 Thread Sergey Bylokhov
On Mon, 4 Oct 2021 14:54:27 GMT, Alexander Zvegintsev wrote: > This fix simply describes that the `java.awt.im.InputContext` is a dummy > implementation, which may not conform its spec. I am fine with any solution but think the check will be simpler and safer, and later we will be able to cha

Re: RFR: 8274864: Remove Amman/Cairo hacks in ZoneInfoFile

2021-10-07 Thread Iris Clark
On Thu, 7 Oct 2021 21:30:22 GMT, Naoto Sato wrote: > While working on tzdata2021c update, I noticed there is a dead code in > `sun.util.calendar.ZoneInfoFile`, which was used to tweak the rules for > `endOfDay` for certain cases. These are no longer needed as JDK's code is > already capable of

RFR: 8274864: Remove Amman/Cairo hacks in ZoneInfoFile

2021-10-07 Thread Naoto Sato
While working on tzdata2021c update, I noticed there is a dead code in `sun.util.calendar.ZoneInfoFile`, which was used to tweak the rules for `endOfDay` for certain cases. These are no longer needed as JDK's code is already capable of dealing with transitions beyond the end of the day. ---

Re: RFR: 8274879: Replace uses of StringBuffer with StringBuilder within java.base classes

2021-10-07 Thread Naoto Sato
On Thu, 9 Sep 2021 06:50:21 GMT, Andrey Turbanov wrote: > StringBuffer is a legacy synchronized class. There are more modern > alternatives which perform better: > 1. Plain String concatenation should be preferred > 2. StringBuilder is a direct replacement to StringBuffer which generally have

Integrated: 8274407: (tz) Update Timezone Data to 2021c

2021-10-07 Thread Naoto Sato
On Wed, 6 Oct 2021 01:24:49 GMT, Naoto Sato wrote: > This PR is to upgrade the time zone data in the JDK to IANA's tzdata2021c > level. Note that the tz data is "as is", as released by IANA. No `merged > links` are retracted. > The PR also fixes two issues along with the 2021c upgrade. This pu

RFR: 8274893: Update java.desktop classes to use try-with-resources

2021-10-07 Thread Andrey Turbanov
8274893: Update java.desktop classes to use try-with-resources - Commit messages: - [PATCH] Use try-with-resources to close resources in java.desktop - [PATCH] Use try-with-resources to close resources in java.desktop - [PATCH] Use try-with-resources to close InputStream in java.de

Re: RFR: 8274806: Simplify equals() call on nullable variable and a constant in java.desktop

2021-10-07 Thread Pankaj Bansal
On Sat, 2 Oct 2021 09:14:49 GMT, Andrey Turbanov wrote: > Flipping arguments of 'equals' method, allows simplifying boolean > expressions: now we can remove redundant null check before. looks good to me - Marked as reviewed by pbansal (Reviewer). PR: https://git.openjdk.java.net

Re: RFR: 8274806: Simplify equals() call on nullable variable and a constant in java.desktop

2021-10-07 Thread Sergey Bylokhov
On Sat, 2 Oct 2021 09:14:49 GMT, Andrey Turbanov wrote: > Flipping arguments of 'equals' method, allows simplifying boolean > expressions: now we can remove redundant null check before. Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5794

RFR: 8274879: Replace uses of StringBuffer with StringBuilder within java.base classes

2021-10-07 Thread Andrey Turbanov
StringBuffer is a legacy synchronized class. There are more modern alternatives which perform better: 1. Plain String concatenation should be preferred 2. StringBuilder is a direct replacement to StringBuffer which generally have better performance In [JDK-8264029](https://bugs.openjdk.java.net/