RFR: 8274806: Simplify equals() call on nullable variable and a constant in java.desktop

2021-10-05 Thread Andrey Turbanov
Flipping arguments of 'equals' method, allows simplifying boolean expressions: now we can remove redundant null check before. - Commit messages: - [PATCH] Simplify equals() call on nullable variable and a constant in java.desktop - [PATCH] Simplify equals() call on nullable variab

Re: RFR: 8274806: Simplify equals() call on nullable variable and a constant in java.desktop

2021-10-05 Thread Sergey Bylokhov
On Sat, 2 Oct 2021 09:14:49 GMT, Andrey Turbanov wrote: > Flipping arguments of 'equals' method, allows simplifying boolean > expressions: now we can remove redundant null check before. Looks fine src/java.desktop/share/classes/javax/swing/JSplitPane.java line 1000: > 998: leftCo

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows [v3]

2021-10-05 Thread Alan Bateman
On Wed, 6 Oct 2021 05:04:28 GMT, Ichiroh Takiguchi wrote: >> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. >> After JDK18-b13, javac and some other langtool command's usage were garbled >> on Japanese Windows. >> These commands use PrintWriter instead of standard out/err with PrintStream.

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows [v2]

2021-10-05 Thread Ichiroh Takiguchi
On Mon, 4 Oct 2021 16:24:18 GMT, Naoto Sato wrote: >> Ichiroh Takiguchi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8274544: Langtools command's usage were garbled on Japanese Windows > > src/jdk.compiler/share/classes/com/sun/tools/

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows [v3]

2021-10-05 Thread Ichiroh Takiguchi
> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. > After JDK18-b13, javac and some other langtool command's usage were garbled > on Japanese Windows. > These commands use PrintWriter instead of standard out/err with PrintStream. Ichiroh Takiguchi has updated the pull request incrementally wi

RFR: 8274407: (tz) Update Timezone Data to 2021c

2021-10-05 Thread Naoto Sato
This PR is to upgrade the time zone data in the JDK to IANA's tzdata2021c level. Note that the tz data is "as is", as released by IANA. No `merged links` are retracted. The PR also fixes two issues along with the 2021c upgrade. - Commit messages: - Fix for Asia/Amman test case erro

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows [v2]

2021-10-05 Thread Naoto Sato
On Mon, 4 Oct 2021 07:13:37 GMT, Ichiroh Takiguchi wrote: >> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. >> After JDK18-b13, javac and some other langtool command's usage were garbled >> on Japanese Windows. >> These commands use PrintWriter instead of standard out/err with PrintStream.

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows

2021-10-05 Thread Ichiroh Takiguchi
On Mon, 4 Oct 2021 10:24:01 GMT, Jan Lahoda wrote: >> Helllo @naotoj . >> I used `System.console()` and `Console.charset()`. >> >> The following executables had same issue, I fixed them. >>> jar.exe, javac.exe, javadoc.exe, javap.exe, jdeps.exe, jlink.exe, jmod.exe, >>> jpackage.exe >> >> I co