Re: RFR: 8269698: Specification for methods of java.awt.im.InputContext should mention that they do nothing

2021-10-04 Thread Naoto Sato
On Mon, 4 Oct 2021 14:54:27 GMT, Alexander Zvegintsev wrote: > This fix simply describes that the `java.awt.im.InputContext` is a dummy > implementation, which may not conform its spec. I'd agree we add clarification to the spec, instead of adding parameter checks. Java input methods became l

Re: RFR: 8269698: Specification for methods of java.awt.im.InputContext should mention that they do nothing

2021-10-04 Thread Sergey Bylokhov
On Mon, 4 Oct 2021 18:07:48 GMT, Alexander Zvegintsev wrote: > So those validation of the parameters enforcements will be an almost dead > code, only used by synthetic specification test. But is it worth it to update the spec in stone that these methods will return null/false/no-exceptions fo

Re: RFR: 8269698: Specification for methods of java.awt.im.InputContext should mention that they do nothing

2021-10-04 Thread Sergey Bylokhov
On Mon, 4 Oct 2021 18:07:48 GMT, Alexander Zvegintsev wrote: > Another solution is to make this class abstract. It won't help, since they will subclass this class and call the parent methods, which they do a few times already for some other cases. - PR: https://git.openjdk.java.n

Re: RFR: 8269698: Specification for methods of java.awt.im.InputContext should mention that they do nothing

2021-10-04 Thread Alexander Zvegintsev
On Mon, 4 Oct 2021 17:25:16 GMT, Sergey Bylokhov wrote: > If the problem is in the validation of the parameters maybe we can enforce it? It is one of possible solutions. Also we have a following javadoc: /** * Constructs an InputContext. * This method is protected so clients ca

Re: RFR: 8269698: Specification for methods of java.awt.im.InputContext should mention that they do nothing

2021-10-04 Thread Sergey Bylokhov
On Mon, 4 Oct 2021 14:54:27 GMT, Alexander Zvegintsev wrote: > This fix simply describes that the `java.awt.im.InputContext` is a dummy > implementation, which may not conform its spec. If the problem is in the validation of the parameters maybe we can enforce it? - PR: https://g

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows [v2]

2021-10-04 Thread Naoto Sato
On Mon, 4 Oct 2021 07:13:37 GMT, Ichiroh Takiguchi wrote: >> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. >> After JDK18-b13, javac and some other langtool command's usage were garbled >> on Japanese Windows. >> These commands use PrintWriter instead of standard out/err with PrintStream.

Integrated: 8274658: ISO 4217 Amendment 170 Update

2021-10-04 Thread Naoto Sato
On Fri, 1 Oct 2021 18:57:28 GMT, Naoto Sato wrote: > This is to incorporate the ISO 4217 amendment #170, which has been released > today, effective immediately. This pull request has now been integrated. Changeset: f2404d60 Author:Naoto Sato URL: https://git.openjdk.java.net/jdk/co

RFR: 8269698: Specification for methods of java.awt.im.InputContext should mention that they do nothing

2021-10-04 Thread Alexander Zvegintsev
This fix simply describes that the `java.awt.im.InputContext` is a dummy implementation, which may not conform its spec. - Commit messages: - rewording - initial Changes: https://git.openjdk.java.net/jdk/pull/5806/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5806&r

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows

2021-10-04 Thread Jan Lahoda
On Mon, 4 Oct 2021 08:47:26 GMT, Ichiroh Takiguchi wrote: >> The encoding used in `Log.java` should first check whether it is run within >> console or not. If `System.console()` returns the console, its `.charset()` >> should be used instead of `native.encoding` value. >> As to the jshell issu

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows

2021-10-04 Thread Ichiroh Takiguchi
On Fri, 1 Oct 2021 18:14:11 GMT, Naoto Sato wrote: >> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. >> After JDK18-b13, javac and some other langtool command's usage were garbled >> on Japanese Windows. >> These commands use PrintWriter instead of standard out/err with PrintStream. > > The

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows [v2]

2021-10-04 Thread Ichiroh Takiguchi
> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. > After JDK18-b13, javac and some other langtool command's usage were garbled > on Japanese Windows. > These commands use PrintWriter instead of standard out/err with PrintStream. Ichiroh Takiguchi has updated the pull request incrementally wi