On Fri, 10 Sep 2021 23:20:11 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert two fixes
Marked as reviewed by iris (Reviewer).
---
On Fri, 10 Sep 2021 21:52:36 GMT, John R Rose wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert two fixes
>
> src/java.base/share/classes/java/nio/channels/FileChannel.java line 567:
>
>> 565: *
> 8273616: Fix trivial doc typos in the java.base module
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision:
Revert two fixes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5475/files
- new: https://git.openjdk.j
On Fri, 10 Sep 2021 12:21:41 GMT, Naoto Sato wrote:
>> Simple spec clarification. A CSR has also been drafted
>> (https://bugs.openjdk.java.net/browse/JDK-8273296).
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes t
On Fri, 10 Sep 2021 21:51:45 GMT, John R Rose wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> src/java.base/share/classes/java/nio/channels/AsynchronousFileChannel.java
> line 399:
>
>> 397: * If {@code true} then this method is required to force
>> changes
>
On Fri, 10 Sep 2021 21:16:19 GMT, Pavel Rappo wrote:
> 8273616: Fix trivial doc typos in the java.base module
Approved, except for two changes commented above: the original "it need only
force" is correct usage, and "it needs only force" is not good usage, but "it
only needs to force" would be
8273616: Fix trivial doc typos in the java.base module
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.java.net/jdk/pull/5475/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5475&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8273616
Stats
On Fri, 10 Sep 2021 20:57:34 GMT, Ian Graves wrote:
>> The duplicate condition in this chain of expressions needs to be shrunk to
>> drop a couple of character that are not excluded spacing marks.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the l
On Fri, 10 Sep 2021 20:57:34 GMT, Ian Graves wrote:
>> The duplicate condition in this chain of expressions needs to be shrunk to
>> drop a couple of character that are not excluded spacing marks.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the l
> The duplicate condition in this chain of expressions needs to be shrunk to
> drop a couple of character that are not excluded spacing marks.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Refactoring test to whitebox
-
On Fri, 10 Sep 2021 20:35:25 GMT, Naoto Sato wrote:
>> Small spec clarification. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reflecting review comment.
Marked as reviewed by joehw
On Fri, 10 Sep 2021 20:32:03 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line
>> 120:
>>
>>> 118: * the locale sensitive services separated by a comma. It is only read
>>> and cached at
>>> 119: * the initialization of this class, so the lat
> Small spec clarification. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflecting review comment.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5457/files
- new:
On Fri, 10 Sep 2021 18:11:37 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflecting review comment.
>
> src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line 120:
>
>> 118: * t
On Thu, 9 Sep 2021 23:29:24 GMT, Naoto Sato wrote:
> Small spec clarification. Corresponding CSR has also been drafted.
src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line 120:
> 118: * the locale sensitive services separated by a comma. It is only read
> and cached at
>
On Fri, 10 Sep 2021 12:21:41 GMT, Naoto Sato wrote:
>> Simple spec clarification. A CSR has also been drafted
>> (https://bugs.openjdk.java.net/browse/JDK-8273296).
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes t
> Simple spec clarification. A CSR has also been drafted
> (https://bugs.openjdk.java.net/browse/JDK-8273296).
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pul
17 matches
Mail list logo
