On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
The changes in the src/java.desktop/ looks fine.
Filed: https://bugs.openjdk.java.net/browse/JDK-8272863
-
Marked as reviewed by s
Collections.sort is just a wrapper, so it is better to use an instance method
directly.
-
Commit messages:
- [PATCH] Replace usages of Collections.sort with List.sort call in public
java modules
Changes: https://git.openjdk.java.net/jdk/pull/5229/files
Webrev: https://webrevs.ope
On Mon, 23 Aug 2021 17:57:52 GMT, Sergey Bylokhov wrote:
>> Maybe it's kind of a protection from a race. Yet it's possible either way:
>> another thread could see `essentialTags == null` before this one initialises
>> the field.
>
> I think we can drop it completely.
Agree.
-
PR:
On Mon, 23 Aug 2021 13:08:02 GMT, Alexey Ivanov wrote:
>> Looks like there's no purpose, `tags` is not used after assignment
>
> Maybe it's kind of a protection from a race. Yet it's possible either way:
> another thread could see `essentialTags == null` before this one initialises
> the field.
Please review the fix to the subject issue. When instant seconds and zone
co-exist in parsed data, instant seconds was not resolved correctly from them.
-
Commit messages:
- 8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is
wrong
Changes: https://git.open
On Mon, 23 Aug 2021 06:35:34 GMT, Сергей Цыпанов
wrote:
>> src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFIFD.java
>> line 64:
>>
>>> 62: Set tags = essentialTags;
>>> 63: if (tags == null) {
>>> 64: essentialTags = Set.of(
>>
>> What is the purpos
