On Thu, 17 Jun 2021 13:56:00 GMT, Daniel Fuchs wrote:
>> It is your codebase, not mine, so it is up to you. Aligning things by column
>> is generally frowned on in most style guides because it handles refactoring
>> poorly, resulting in lots of needless change (or people forgetting to
>> reali
On Wed, 16 Jun 2021 10:57:07 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.time`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new
On Wed, 16 Jun 2021 16:43:20 GMT, Stephen Colebourne
wrote:
>> The vertical alignment improves readability in these short-line cases.
>> Removing the spaces before the arrows will make it a little harder to
>> discern the difference between the cases.
>
> It is your codebase, not mine, so it i
